900372 - Update key names for the latest D3E draft

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

We should update the key names which are updated in the latest D3E draft after it fixes all pending issues of key name definition.

This is meta bug for it.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

First, we should rename key names specified by old spec to their new names. Then, we can avoid the compatibility issue with all browsers in the future.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

We're waiting fix of some spec bugs for very long time now. I think that for several B2G product, we should land finished patches as soon as possible if we don't get response from D3E WG in this month.

I think that bug 936319 and bug 1023067 need to wait spec bug fix. But for others, we should land them even if we have risk. (Especially about Launching media player keys have a spec bug (https://www.w3.org/Bugs/Public/show_bug.cgi?id=26141), but these keys are not so important for actual web applications). Even if some of them have risk to be renamed again, I believe that it's worthwhile to land them for better compatibility with at least for the latest spec. (And web apps can check both legacy and new key values easy. E.g., (event.key == "Left" || event.key == "ArrowLeft").

So, I'd like to suggest that all bugs which blocks this bug (except bug 936319 and bug 1023067) should be landed this cycle for going to next step. How about you, smaug?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Sounds good to me.
When landing something not yet in the spec, would be good to update the relevant spec bug to say what
we're going to do. (Since if we're the first one to implement it and there are no strong reasons to do something else in the spec, the spec could just follow what is already done in Gecko.)

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thanks. I'll prepare to land them next week. We need to backout the warning messages which notify the key names will be updated.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Remove warning messages for obsolete .key values

I'll land this and other patches except for bug 936319 and bug 1023067.

# Locally, I merged them with the latest m-c. Of course, they are not changed logically.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8541550 [details] [diff] [review]
Remove warning messages for obsolete .key values

(not quite clear if we really have to remove these warnings, but I think it should be ok.)

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug] (away-ish 12/28-1/2) from comment #6)
> Comment on attachment 8541550 [details] [diff] [review]
> Remove warning messages for obsolete .key values
> 
> (not quite clear if we really have to remove these warnings, but I think it
> should be ok.)

I think that we should do it because we were claimed for a lot of deprecated warning messages and the code refers old constants of key value indexes.

https://hg.mozilla.org/integration/mozilla-inbound/rev/892cea1c2efc

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/892cea1c2efc

Comment 9

[Kohei Yoshino]

https://developer.mozilla.org/en-US/Firefox/Releases/37
https://developer.mozilla.org/en-US/Firefox/Releases/37/Site_Compatibility
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent.key#Key_values

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

See bug 1232915 for next updates.