900430 - Should be able to Tab complete and cycle through the completion suggestions in the markup view.

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Girish Sharma [:Optimizer]]

When editing the style attribute in markup view, you get CSS properties and values suggestions. The suggestions in the popup can be cycles throug husing up/down arrows, but you have to press right arrow to complete that property and keep typing. In rule view, it makes direct sense to press TAB key to complete the selected suggestino and move on to the next editor, but in markup view, you have to remain in the same editor . Currently, take the following example:

style="di|

where the cursor is '|' . The user will now have a popup giving the following suggestions : "direction" and "display". Now the user shold be able to press tab once to complete to "direction" and one more time to cycle to "display" without leaving the editor as he has to now write the value of the property "display".

Comment 1

[Girish Sharma [:Optimizer]]

Attachment: patch v0.1

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Does this also work when adding mulotiple attributes in the markup view?

Say you have the following attribute:
style="display:none;"

Well, you can edit display:none and change it to:
display:none;" collapsed="true"

So do the suggestions work when adding new attributes in this way?

Comment 3

[Girish Sharma [:Optimizer]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #2)
> Does this also work when adding mulotiple attributes in the markup view?
> 
> Say you have the following attribute:
> style="display:none;"
> 
> Well, you can edit display:none and change it to:
> display:none;" collapsed="true"
> 
> So do the suggestions work when adding new attributes in this way?

If by work you mean "Should not show suggestion when cursor is in the collapsed=\"true\" area", then no. It still shows suggestions. I should probably fix that in a followup. I tested for 

display: none" foobar

and 

display: none " foobar "

which does not create a new attribute, forgot to test something like

display: none " foobar = " "

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 786828 [details] [diff] [review]
patch v0.1

Review of attachment 786828 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Girish Sharma [:Optimizer] from comment #3)
> (In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #2)
> > Does this also work when adding mulotiple attributes in the markup view?
> > 
> > Say you have the following attribute:
> > style="display:none;"
> > 
> > Well, you can edit display:none and change it to:
> > display:none;" collapsed="true"
> > 
> > So do the suggestions work when adding new attributes in this way?
> 
> If by work you mean "Should not show suggestion when cursor is in the
> collapsed=\"true\" area", then no. It still shows suggestions. I should
> probably fix that in a followup. I tested for 
> 
> display: none" foobar
> 
> and 
> 
> display: none " foobar "
> 
> which does not create a new attribute, forgot to test something like
> 
> display: none " foobar = " "

In that case please log a follow up bug so that it will work in that situation.

Comment 5

[Girish Sharma [:Optimizer]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #4)

> In that case please log a follow up bug so that it will work in that
> situation.

The desired behavior is to not show suggestions in this case, right ?

Comment 6

[Girish Sharma [:Optimizer]]

Some failures: https://tbpl.mozilla.org/?tree=Try&rev=2cc8027604dd trying to see why they are happening.

Comment 7

[Girish Sharma [:Optimizer]]

Attachment: rebased patch

Rebased on latest fx-team.

multiple green trys :
https://tbpl.mozilla.org/?tree=Try&rev=51663149477a
https://tbpl.mozilla.org/?tree=Try&rev=a8af567e17aa

Comment 8

[Girish Sharma [:Optimizer]]

landed in fx-team: https://hg.mozilla.org/integration/fx-team/rev/ab2036982463

Comment 9

[Girish Sharma [:Optimizer]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #4)
> In that case please log a follow up bug so that it will work in that
> situation.

filed bug 916582

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ab2036982463