Closed
Bug 900585
Opened 12 years ago
Closed 12 years ago
Add support for b2g-inbound to mcMerge
Categories
(Tree Management :: Bugherder, defect)
Tree Management
Bugherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ryanvm, Assigned: ryanvm)
References
Details
Attachments
(2 files, 1 obsolete file)
|
2.81 KB,
patch
|
graememcc
:
review+
|
Details | Diff | Splinter Review |
|
3.57 KB,
patch
|
graememcc
:
review+
|
Details | Diff | Splinter Review |
Right now, mcMerge doesn't know what b2g-inbound is.
| Assignee | ||
Comment 1•12 years ago
|
||
Might as well do some cleanup while I'm here. I'm sure eventually we'll tie these separate configs together.
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #784465 -
Flags: review?(graememcc_firefox)
| Assignee | ||
Comment 2•12 years ago
|
||
Attachment #784470 -
Flags: review?(graememcc_firefox)
| Assignee | ||
Comment 3•12 years ago
|
||
No idea WTF I did there...
Attachment #784465 -
Attachment is obsolete: true
Attachment #784465 -
Flags: review?(graememcc_firefox)
Attachment #784471 -
Flags: review?(graememcc_firefox)
Comment 4•12 years ago
|
||
Comment on attachment 784471 [details] [diff] [review]
part 1 - remove repositories that aren't supported in tbpl anymore
Thanks for the cleanup!
Attachment #784471 -
Flags: review?(graememcc_firefox) → review+
Comment 5•12 years ago
|
||
Comment on attachment 784470 [details] [diff] [review]
part 2 - add b2g-inbound and a couple other supported b2g18 repos
Review of attachment 784470 [details] [diff] [review]:
-----------------------------------------------------------------
::: mcmerge/js/Config.js
@@ +99,5 @@
> + repo: "releases/mozilla-b2g18",
> + unconditionalFlag: true,
> + trackedTree: true,
> + synonyms: ["b2g18", "mozilla-b2g18"]
> + }
Nit: need a trailing comma on the closing brace. Same for the v1.0.1 and 1.1.0hd properties.
@@ -258,5 @@
> unconditionalFlag: false,
> trackedTree: true,
> synonyms: ["releases/comm-esr17", "comm-esr17"]
> },
> - "mozilla-b2g18": {
Nit: comm-esr17 is now the final property in the tree info object. Remove its trailing comma.
Attachment #784470 -
Flags: review?(graememcc_firefox) → review+
| Assignee | ||
Comment 6•12 years ago
|
||
Pushed with nits addressed. Thanks!
https://hg.mozilla.org/webtools/tbpl/rev/9c722ab4841c
https://hg.mozilla.org/webtools/tbpl/rev/7af46fbdaff0
Comment 7•12 years ago
|
||
In production :-)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: Webtools → Tree Management
Updated•11 years ago
|
Component: TBPL → mcMerge
You need to log in
before you can comment on or make changes to this bug.
Description
•