Closed
Bug 900595
Opened 8 years ago
Closed 8 years ago
[crash reporting] Once always send a report has been selected, selecting any other option is ignored with system crashes
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(blocking-b2g:leo+, firefox24 wontfix, firefox25 wontfix, firefox26 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)
People
(Reporter: nhirata, Assigned: supadennis.lee)
Details
Attachments
(1 file)
436 bytes,
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
Gecko http://hg.mozilla.org/releases/mozilla-b2g18/rev/aff662053ee8 Gaia ddb922ed002e88d01f71199da32ff75911b455b2 BuildID 20130801070210 Version 18.0 1. go to settings -> improve firefox os -> crash reports -> always send a report 2. adb shell ps |grep b2g 3. adb kill -11 <pid of /system/b2g/b2g process> 4. phone will reboot; wait for it to come back up 5. go to settings -> improve firefox os -> crash reports -> ask each time or never send a report 6. adb shell ps |grep b2g 7. adb kill -11 <pid of /system/b2g/b2g process> 8. phone will reboot; wait for it to come back up 9. adb shell ls -al /data/b2g/mozilla/Crash\ Reports/submitted 10. adb shell ls -al /data/b2g/mozilla/Crash\ Reports/pending Expected: following the second time of crashing we should not be sending the system crash, since the option should require a dialog. Actual: following the second time of crashing, we are sending the report without showing a dialog for the crash reporting if ask eat time is selected. We are sending the report when never send is selected. Note: 1. if we originally select never send on the crash reporting, then it will store in pending: bug 900588 2. this is with system crashes which are handled differently than app crashes
Comment 1•8 years ago
|
||
I think this is duplicated with bug 836071. In bug 836071, same behavior is described and handle it with bug 867829. With patches on bug 867829, application crashes are handled, because b2g process removes dump files witchi will not be sent. But, if crash occurs on b2g process no one could care. So, this bug is a part of 836071. I think, it's better to make some link for that.
Comment 2•8 years ago
|
||
Here is a problem I see. Bug 867829 is fixed on Nightly / master. It is not on b2g-18.
Comment 3•8 years ago
|
||
Triage - leo+'ing as user options are not respected when this bug is hit. Potential data charge and/or privacy concerns.
blocking-b2g: leo? → leo+
Comment 4•8 years ago
|
||
Hi Fabrice, As the guru on crash reporting, can you please look into this bug OR reassign as needed? Thanks!!
Flags: needinfo?(fabrice)
Comment 5•8 years ago
|
||
Is this still happening since the uplift of Bug 867829 to 1.1 ?
Flags: needinfo?(fabrice)
Assignee | ||
Comment 6•8 years ago
|
||
I attach this patch. AFAIK, the problem directly to the changed setting value(about settings -> improve firefox os -> crash reports -> always send a report =>[Change] Never send a report ) doesn't reflect is that /data/b2g/mozilla/*.default/pref.js. Setting changes immediately reflected in the value pref.js when I think that the problem does not occur.
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 793773 [details] [diff] [review] bug900595.patch Expected: following the second time of crashing we should not be sending the system crash, since the option should require a dialog. Actual: following the second time of crashing, we are sending the report without showing a dialog for the crash reporting if ask each time is selected. We are sending the report when never send is selected. +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ This problem directly to the changed setting value doesn't reflect is that pref.js. Setting value just save settingDB. So, we should make settingDB equal to the value of pref.js. Review on this patch, plz. The function of savePrefFile can address the above problem. We set the value equal to the value of the pref should make.
Attachment #793773 -
Flags: review?(fabrice)
Comment 8•8 years ago
|
||
Comment on attachment 793773 [details] [diff] [review] bug900595.patch Review of attachment 793773 [details] [diff] [review]: ----------------------------------------------------------------- ::: b2g/chrome/content/settings.js @@ +323,4 @@ > } else { > Services.prefs.clearUserPref('app.reportCrashes'); > } > + Services.prefs.savePrefFile(null); Nit: add a comment to explain why we do that (like for the devtools.debugger.remote-enabled setting): // This preference is consulted during startup
Attachment #793773 -
Flags: review?(fabrice) → review+
Comment 9•8 years ago
|
||
Fabrice, Would you be able to complete the bug fix and landing?
Flags: needinfo?(fabrice)
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/33d7577f289d
Flags: needinfo?(fabrice)
Comment 11•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/33d7577f289d
Assignee: nobody → supadennis.lee
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 12•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/796d0adce82b
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-b2g-v1.1hd:
--- → affected
status-firefox24:
--- → wontfix
status-firefox25:
--- → wontfix
status-firefox26:
--- → fixed
Comment 13•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/796d0adce82b
Target Milestone: --- → 1.1 QE5
You need to log in
before you can comment on or make changes to this bug.
Description
•