900671 - Switch Thunderbird's Windows unit test builders to iX hardware

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mark Banner (:standard8)]

Attachment: Port to iX hardware for TB on comm-central and try-comm-central

Given our current issues on Thunderbird, and the fact that all our unit tests are now completely broken on Windows, without an upgrade to python, I think we should just bite the bullet and swap the builders to building on the same hardware as Firefox is.

The attached patch ports what I believe are the relevant parts necessary to switch the TB unit test boxes to iX hardware - for comm-central and try-comm-central.

I've not tested it, as I do not have an appropriate environment set up.

Note: I've purposely not included any MERGE DAY stuff yet. If this works, then I'll look at porting this to TB 24, so that we can catch up with the FF chain, and not have to wait for the esr to end before making the boxes redundant.

Comment 1

[Chris Cooper [:coop] (he/him)]

Comment on attachment 784572 [details] [diff] [review]
Port to iX hardware for TB on comm-central and try-comm-central

Review of attachment 784572 [details] [diff] [review]:
-----------------------------------------------------------------

The patch passes the most basic of muster in staging. I'd like to run it and a similar patch for bug 892032 against an actual sendchange in staging tomorrow before landing.

Comment 2

[Chris Cooper [:coop] (he/him)]

Initial results are promising.

First, the tests run on the new XP hosts, so bug 900290 doesn't seem to be an issue.

Second, only one failure on WinXP for xpcshell, so not too much fixup to be done either.

Still waiting on Win7 results.

Comment 3

[Chris Cooper [:coop] (he/him)]

(In reply to Chris Cooper [:coop] from comment #2) 
> Still waiting on Win7 results.

Same results on Win7: tests run, only 1 failure.

Comment 4

[Chris Cooper [:coop] (he/him)]

mozmill tests passed for both Win7 and WinXP.

Comment 5

[Chris Cooper [:coop] (he/him)]

Comment on attachment 784572 [details] [diff] [review]
Port to iX hardware for TB on comm-central and try-comm-central

https://hg.mozilla.org/build/buildbot-configs/rev/72a2caf67147

Comment 6

[Armen [:armenzg]]

Live in production.

Comment 7

[Chris Cooper [:coop] (he/him)]

Mark: so this seems to have stuck on comm-central. How do you want to handle moving other branches to the new hardware?

Comment 8

[Mark Banner (:standard8)]

Attachment: Migrate to Aurora and Beta

Chris, I'm fine with straight rolling this out to comm-aurora and comm-beta as it only affects unit test builders. I believe that's also enough to mean that we won't be on these past the end of esr 17, so I think that will be in sync with FF.

Here's the patch that should put these onto aurora/beta and adds a couple of merge day comments.

Comment 9

[Chris Cooper [:coop] (he/him)]

Comment on attachment 795599 [details] [diff] [review]
Migrate to Aurora and Beta

Review of attachment 795599 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nits fixed.

::: mozilla-tests/thunderbird_config.py
@@ +325,3 @@
>  BRANCHES['comm-beta']['platforms']['win32']['slave_platforms'] = ['xp', 'win7']
>  BRANCHES['comm-beta']['platforms']['linux']['slave_platforms'] = ['fedora']
>  BRANCHES['comm-beta']['platforms']['linux64']['slave_platforms'] = ['fedora64']

Need to remove the slave_platforms fix ups too.

@@ +332,3 @@
>  BRANCHES['comm-aurora']['platforms']['win32']['slave_platforms'] = ['xp', 'win7']
>  BRANCHES['comm-aurora']['platforms']['linux']['slave_platforms'] = ['fedora']
>  BRANCHES['comm-aurora']['platforms']['linux64']['slave_platforms'] = ['fedora64']

Need to remove the slave_platforms fix ups too.

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 795599 [details] [diff] [review]
Migrate to Aurora and Beta

https://hg.mozilla.org/build/buildbot-configs/rev/bef5cd2bdfb3

Comment 11

[John Hopkins (:jhopkins)]

In production

Comment 12

[Mark Banner (:standard8)]

All working great, thanks!