892032 - Migrate Thunderbird tests from Fedora to Ubuntu

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task, P2)

Description

[John Hopkins (:jhopkins)]

Migrate Thunderbird tests from Fedora to Ubuntu.

Firefox is currently partially moved over, with some dev work still to do.  For context, some related bugs: bug 864866, bug 850101, bug 850105.

Where is Ubuntu on "the train"?  Per rail: Depending on the test suite. Some mozilla-release suites are covered by Ubuntu some of mozilla-central aren't covered yet.

Comment 1

[Chris Cooper [:coop] (he/him)]

I'll take a stab at the config changes for this. If I get too far into mock configs, I'll be out of my depth though.

Comment 2

[Chris Cooper [:coop] (he/him)]

Hoping this will obviate the need for bug 900066.

Comment 3

[Chris Cooper [:coop] (he/him)]

Following along from the work in bug 900671, I have a working patch now for moving the Thunderbird testers from Fedora to Ubuntu.

Didn't hit any python issues, so bug 900066 and bug 900290 seem moot.

The results:

Ubuntu32
xpcshell: 1 failure
mozmill:  pass

Ubuntu64:
xpcshell: pass
mozmill:  6 failures

Comment 4

[Chris Cooper [:coop] (he/him)]

(In reply to Chris Cooper [:coop] from comment #3) 
> Ubuntu32
> xpcshell: 1 failure
> mozmill:  pass
> 
> Ubuntu64:
> xpcshell: pass
> mozmill:  6 failures

I crossed the streams with the XP results:

Ubuntu32:
xpcshell: pass
mozmill:  7 failures

Ubuntu64:
xpcshell: pass
mozmill:  6 failures

...which makes more sense.

Comment 5

[Chris Cooper [:coop] (he/him)]

Attachment: bug892032_thunderbird_to_ubuntu.diff

Follows the same pattern used for the move to Windows iX hardware in bug 900671. Introduces a separate list, FEDORA_REV3_BRANCHES, in case we need to toggle these platforms/branches separately.

Already running in staging, as indicated previously (comment #3).

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 793795 [details] [diff] [review]
bug892032_thunderbird_to_ubuntu.diff

Review of attachment 793795 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comments-fixed. I'm happy to swing at this again if you feel I should.

::: mozilla-tests/thunderbird_config.py
@@ +312,5 @@
>  BRANCHES['comm-release']['repo_path'] = "releases/comm-release"
>  del BRANCHES['comm-release']['platforms']['win32']['xp-ix']
>  del BRANCHES['comm-release']['platforms']['win32']['win7-ix']
> +del BRANCHES['comm-release']['platforms']['linux']['ubuntu32_vm']
> +del BRANCHES['comm-release']['platforms']['linux64']['ubuntu64_vm']

for these del's you also need to reset slave_platforms. c.f. (first part of) http://mxr.mozilla.org/build/source/buildbot-configs/mozilla-tests/config.py#1581

@@ +357,5 @@
> +for branch in set(BRANCHES.keys()) - set(FEDORA_REV3_BRANCHES):
> +    if 'linux' in BRANCHES[branch]['platforms']:
> +        del BRANCHES[branch]['platforms']['linux']['fedora']
> +    if 'linux64' in BRANCHES[branch]['platforms']:
> +        del BRANCHES[branch]['platforms']['linux64']['fedora64']

if you're dropping fedora here, you'll also want to change slave_platforms as well to just list ubuntu

Comment 7

[Chris Cooper [:coop] (he/him)]

Attachment: bug892032_thunderbird_to_ubuntu_v2.diff

Addresses nits in comment #6, I hope!

Comment 8

[Chris Cooper [:coop] (he/him)]

Comment on attachment 794046 [details] [diff] [review]
bug892032_thunderbird_to_ubuntu_v2.diff

https://hg.mozilla.org/build/buildbot-configs/rev/67fc3d5477fb

Comment 9

[Armen [:armenzg]]

  File "/usr/local/Cellar/python/2.7.3/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot-0.8.2_hg_not_trusting_file_Users_armenzg_repos_releng_buildbot_.hg_hgrc_from_untrusted_user_armenzg_group_staff_not_trusting_file_Users_armenzg_repos_releng_buildbot_.hg_hgrc_from_untrusted_user_armenzg_group_staff_26a7af6d64c1_default-py2.7.egg/buildbot/master.py", line 628, in loadConfig
    exec f in localDict
  File "./master.cfg", line 11, in <module>
    import thunderbird_config
  File "/Users/armenzg/repos/buildbot-configs/master/thunderbird_config.py", line 88, in <module>
    platform_config[slave_platform]['slaves'] = sorted(SLAVES[slave_platform])
KeyError: 'ubuntu32_vm'

Comment 10

[Armen [:armenzg]]

Comment on attachment 794046 [details] [diff] [review]
bug892032_thunderbird_to_ubuntu_v2.diff

Backed out from default.

Comment 11

[Chris Cooper [:coop] (he/him)]

Comment on attachment 794046 [details] [diff] [review]
bug892032_thunderbird_to_ubuntu_v2.diff

Re-landed with errant '64' removed. Now passes config checks again.

https://hg.mozilla.org/build/buildbot-configs/rev/a2a551e2c582

Comment 12

[John Hopkins (:jhopkins)]

In production

Comment 13

[Mark Banner (:standard8)]

This is working great, Thanks! There's possibly a few extra oranges in some tests, but generally these are running fine and working well, and we'll fix them up as we go.