901002 - [8.1] Add Windows 8.1 to the OS list for gfx driver blacklisting

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1

- Would it be better to always return DRIVER_OS_WINDOWS_8 for windows 8.1? (I don't think so but check checking)
- There are 3 APPEND_TO_DRIVER_BLOCKLIST_RANGE( DRIVER_OS_WINDOWS_8, should I be setting these for 8.1 a well? How do I tell?

Comment 2

[Brian R. Bondy [:bbondy]]

Hey Bas, been a couple weeks, review ping? :)

Comment 3

[Brian R. Bondy [:bbondy]]

1 month + 1 week review ping :)

Comment 4

[Bas Schouten (:bas.schouten)]

(In reply to Brian R. Bondy [:bbondy] from comment #1)
> Created attachment 785058 [details] [diff] [review]
> Patch v1
> 
> - Would it be better to always return DRIVER_OS_WINDOWS_8 for windows 8.1?
> (I don't think so but check checking)
> - There are 3 APPEND_TO_DRIVER_BLOCKLIST_RANGE( DRIVER_OS_WINDOWS_8, should
> I be setting these for 8.1 a well? How do I tell?

I have no idea on either of these questions. Bjacob is still the most knowledgeable person on our blacklisting system. I suspect the answer to the second question is yes though.

Comment 5

[Brian R. Bondy [:bbondy]]

Please see the previous comment.

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

(In reply to Brian R. Bondy [:bbondy] from comment #1)
> Created attachment 785058 [details] [diff] [review]
> Patch v1
> 
> - Would it be better to always return DRIVER_OS_WINDOWS_8 for windows 8.1?
> (I don't think so but check checking)

I don't think so: it should be useful to be able to have blacklist rules that affect only Windows 8, or only Windows 8.1 ... unless you know something that I don't know, about Windows 8 and Windows 8.1 being really the same for all practical purposes here.

Also, our current blacklisting system is terribly fragile and unpredictable, and we know for instance that it is unsafe to add a new kind of FEATURE, but for all I know, it should be safe to add a new operating system version. We did it fairly recently for Windows 8 and we were fine.


> - There are 3 APPEND_TO_DRIVER_BLOCKLIST_RANGE( DRIVER_OS_WINDOWS_8, should
> I be setting these for 8.1 a well? How do I tell?

It's up to you: do you think that these blacklist rules should apply to Windows 8.1 as well, or not? If you don't know, the safe choice is probably to assume that Windows 8.1 is similar to Windows 8, therefore you need to duplicate these rules for Windows 8.1...

Comment 7

[Brian R. Bondy [:bbondy]]

It could be different enough, but I have no way of knowing. I'll leave it as is for now.

Comment 8

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed0014600bc7

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ed0014600bc7