901110 - IonMonkey: on x64, use a Float32 constants pool

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

The double constants pool on x64 has been introduced while the Float32 patch was made, so it is an nice and easy follow-up for bug 888109.

I'll take care of it except if somebody beats me to it :)

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: proposed fix

We are *this* close to factor all this code in MacroAssembler-x86-shared, if only we didn't have different labels for the uses in the Float and Double structs.

Comment 2

[Sean Stangl [:sstangl]]

Comment on attachment 807043 [details] [diff] [review]
proposed fix

Review of attachment 807043 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/x64/MacroAssembler-x64.cpp
@@ +95,5 @@
>          bind(&dbl.uses);
>          masm.doubleConstant(dbl.value);
>      }
>  
> +    // No need to align on sizeof(float) as we are aligned on sizeof(double);

Not necessarily -- the condition above must be changed to "if (!doubles_.empty() || !floats_.empty())".

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Nice catch, thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/ccbfd1ddb131

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ccbfd1ddb131