Closed
Bug 923328
Opened 11 years ago
Closed 11 years ago
Ionmonkey: fix float32 hash function
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: dougc, Assigned: dougc)
References
Details
Attachments
(1 file)
|
1.40 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
The default hash function is not quite appropriate for a float32. For example, it's failing for NaN objects which can cause the constant pool to be excessively and it degrades performance.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #813386 -
Flags: review?
|
||
Comment 2•11 years ago
|
||
Comment on attachment 813386 [details] [diff] [review] Add a specialized float32 hash function. Review of attachment 813386 [details] [diff] [review]: ----------------------------------------------------------------- I guess you meant to set a reviewer here? In any case, this is nice and we should do it. r=me
Attachment #813386 -
Flags: review? → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd7bb523c5dc
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bd7bb523c5dc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•