Closed Bug 923328 Opened 7 years ago Closed 7 years ago

Ionmonkey: fix float32 hash function

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: dougc, Assigned: dougc)

References

Details

Attachments

(1 file)

The default hash function is not quite appropriate for a float32. For example, it's failing for NaN objects which can cause the constant pool to be excessively and it degrades performance.
Comment on attachment 813386 [details] [diff] [review]
Add a specialized float32 hash function.

Review of attachment 813386 [details] [diff] [review]:
-----------------------------------------------------------------

I guess you meant to set a reviewer here? In any case, this is nice and we should do it. r=me
Attachment #813386 - Flags: review? → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bd7bb523c5dc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.