901454 - The deck added in bug 895543 causes the source editor to not scroll properly

Status: VERIFIED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

STR:

1. Go to http://htmlpad.org/debugger/
2. Open debugger
3. Make sure the toolbox height is rather small (< 300px)
4. Try to scroll the source editor to line 120

Source editor can't scroll.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: dbg-blackbox-scroll.patch

Decks are the best thing ever.

Apart from the fix, I also made the padding take the actual toolbox height into consideration. I think this makes more sense, since not everybody keeps their toolbox at the same size.

Comment 2

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/b45873908380

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 785683 [details] [diff] [review]
dbg-blackbox-scroll.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 895543
User impact if declined: Source editor can't scroll in the debugger :(
Testing completed (on m-c, etc.): locally, fx-team
Risk to taking this patch (and alternatives if risky): None, css only changes
String or IDL/UUID changes made by this patch: None

Comment 4

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/mozilla-central/rev/b45873908380

Comment 5

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/40f91a85e10d

Comment 6

[Ada [:adalucinet]]

Mozilla/5.0 (Windows NT 6.1; rv:25.0) Gecko/20100101 Firefox/25.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0) Gecko/20100101 Firefox/25.0
Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20100101 Firefox/25.0

Reproduced this issue with Nightly 25.0a1 (2013-08-05).
Verified as fixed with Firefox 25 beta 2 (Build ID: 20130923194050).

Comment 7

[Simona Badau, Desktop QA]

Verified as fixed on the latest Aurora 26.0a2.
Verified on Ubuntu 13.04, Mac OS X 10.8 and Windows 7:
Mozilla/5.0 (X11; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:26.0) Gecko/20100101 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20131003004003