Closed
Bug 901471
Opened 12 years ago
Closed 12 years ago
Revamp Contact Settings screen to allow to import / export from / to different sources
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-b2g:koi+)
RESOLVED
FIXED
blocking-b2g | koi+ |
People
(Reporter: noemi, Assigned: borjasalguero)
References
Details
(Whiteboard: [u=commsapps-user c=contacts p=1.5], [Sprint2])
Attachments
(3 files, 1 obsolete file)
Align import access UI (from Contacts->Settings) to any "source" to export one defined for v1.2
Reporter | ||
Updated•12 years ago
|
Whiteboard: [u=commsapps-user c=contacts p=0]
Comment 1•12 years ago
|
||
Wireframe solution for bug
Pages 13 and 14 are the relevant ones
Reporter | ||
Updated•12 years ago
|
Component: Gaia::Contacts → Gaia::Settings
Updated•12 years ago
|
Component: Gaia::Settings → Gaia::Contacts
Summary: Import access UI to any source → Revamp Contact Settings screen to allow to import / export from / to different sources
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → fbsc
Reporter | ||
Updated•12 years ago
|
Whiteboard: [u=commsapps-user c=contacts p=0] → [u=commsapps-user c=contacts p=0], [Sprint2]
Assignee | ||
Updated•12 years ago
|
Whiteboard: [u=commsapps-user c=contacts p=0], [Sprint2] → [u=commsapps-user c=contacts p=1.5], [Sprint2]
Assignee | ||
Comment 3•12 years ago
|
||
Assignee | ||
Comment 4•12 years ago
|
||
This is the other WF to take into account.
Attachment #786334 -
Attachment is obsolete: true
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #786338 -
Flags: review?(jmcf)
Assignee | ||
Updated•12 years ago
|
Attachment #786338 -
Flags: review?(igonzaleznicolas)
Comment 6•12 years ago
|
||
Comment on attachment 786338 [details]
Pull Request
At code level (css&html) everything looks fine to me.
My only concern is about to use the "big" list buttons from "view-settings". In that scenario there isn't a descriptive text below the button label so we may need to use the "normal" list buttons there.
Anyway great work Borja!
Attachment #786338 -
Flags: review?(igonzaleznicolas) → review+
Comment 7•12 years ago
|
||
Comment on attachment 786338 [details]
Pull Request
good work Borja. thanks
Attachment #786338 -
Flags: review?(jmcf) → review+
Assignee | ||
Comment 8•12 years ago
|
||
Thanks for the review! R+, Merging!
Assignee | ||
Comment 9•12 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/1dba2b511bb09eff8d5e18636d08db26799e2483
https://github.com/borjasalguero/gaia/commit/f49a8408d16be1e07201aac92d076f4ee03226b0
Merged!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
blocking-b2g: koi? → koi+
Comment 10•12 years ago
|
||
Please find the visuals corresponding to the specs in the following link:
https://www.dropbox.com/sh/ondeh2eccoby1ce/52SLmxWByv
If you have any question do not hesitate to ask.
Victoria
You need to log in
before you can comment on or make changes to this bug.
Description
•