Last Comment Bug 901537 - Permanent Orange: TEST-UNEXPECTED-FAIL | test_viewWrapper_virtualFolderCustomTerm.js | NS_BASE_STREAM_CLOSED) [nsIOutputStream.write]
: Permanent Orange: TEST-UNEXPECTED-FAIL | test_viewWrapper_virtualFolderCustom...
Status: RESOLVED FIXED
: intermittent-failure
Product: Thunderbird
Classification: Client Software
Component: Testing Infrastructure (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 26.0
Assigned To: Mark Banner (:standard8)
:
Mentors:
Depends on:
Blocks: 896738
  Show dependency treegraph
 
Reported: 2013-08-05 07:57 PDT by Mark Banner (:standard8)
Modified: 2013-08-06 00:53 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed
fixed


Attachments
The fix (1.28 KB, patch)
2013-08-05 12:39 PDT, Mark Banner (:standard8)
Pidgeot18: review+
standard8: approval‑comm‑aurora+
standard8: approval‑comm‑beta+
Details | Diff | Review

Description Mark Banner (:standard8) 2013-08-05 07:57:42 PDT
Since the last major orange, we've been seeing:

https://tbpl.mozilla.org/php/getParsedLog.php?id=26160366&tree=Thunderbird-Aurora#error0

TEST-UNEXPECTED-FAIL | ../../../../mailnews/resources/logHelper.js | Error console says [stackFrame NS_BASE_STREAM_CLOSED: Component returned failure code: 0x80470002 (NS_BASE_STREAM_CLOSED) [nsIOutputStream.write]] - See following stack:
JS frame :: ../../../../mailnews/resources/logHelper.js :: _errorConsoleTunnel.observe :: line 63
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Comment 1 Mark Banner (:standard8) 2013-08-05 08:06:18 PDT
Debugging on try server, indicates we're writing to the socket as it is being closed:

https://hg.mozilla.org/try-comm-central/rev/5da4b9422be6#l2.31

https://tbpl.mozilla.org/php/getParsedLog.php?id=26165740&tree=Thunderbird-Try#error1

=== (Done With Tests)
RECV: 16 close
Received command 16
SEND: 16 OK CLOSE completed
SEND: 
System JS : ERROR resource://testing-common/mailnews/maild.js:457
                     NS_BASE_STREAM_CLOSED: Component returned failure code: 0x80470002 (NS_BASE_STREAM_CLOSED) [nsIOutputStream.write]
Connection Lost 2152398850
Comment 2 Mark Banner (:standard8) 2013-08-05 12:39:24 PDT
Created attachment 785902 [details] [diff] [review]
The fix

Tested on try server - handle the case where the socket gets closed from under us, but we haven't picked it up yet.

Tested on try server and it passed.
Comment 3 Joshua Cranmer [:jcranmer] 2013-08-05 12:41:34 PDT
Comment on attachment 785902 [details] [diff] [review]
The fix

Review of attachment 785902 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/test/fakeserver/maild.js
@@ +89,4 @@
>   * do_test_finished();
>   *****************************************************************************/
>  function nsMailServer(handlerCreator, daemon) {
> +  this._debug = fsDebugAll;

Did you mean to change the default debug settings to All?
Comment 4 Mark Banner (:standard8) 2013-08-05 12:55:00 PDT
Didn't mean to change the default. I've undone that part of the change and landed it:

https://hg.mozilla.org/comm-central/rev/c96309b77ef8
Comment 5 Mark Banner (:standard8) 2013-08-06 00:40:40 PDT
Comment on attachment 785902 [details] [diff] [review]
The fix

[Triage Comment]
Taking this onto aurora & beta to get this fixed there as well.

Note You need to log in before you can comment on or make changes to this bug.