901537 - Permanent Orange: TEST-UNEXPECTED-FAIL | test_viewWrapper_virtualFolderCustomTerm.js | NS_BASE_STREAM_CLOSED) [nsIOutputStream.write]

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Mark Banner (:standard8)]

Since the last major orange, we've been seeing:

https://tbpl.mozilla.org/php/getParsedLog.php?id=26160366&tree=Thunderbird-Aurora#error0

TEST-UNEXPECTED-FAIL | ../../../../mailnews/resources/logHelper.js | Error console says [stackFrame NS_BASE_STREAM_CLOSED: Component returned failure code: 0x80470002 (NS_BASE_STREAM_CLOSED) [nsIOutputStream.write]] - See following stack:
JS frame :: ../../../../mailnews/resources/logHelper.js :: _errorConsoleTunnel.observe :: line 63
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

Comment 1

[Mark Banner (:standard8)]

Debugging on try server, indicates we're writing to the socket as it is being closed:

https://hg.mozilla.org/try-comm-central/rev/5da4b9422be6#l2.31

https://tbpl.mozilla.org/php/getParsedLog.php?id=26165740&tree=Thunderbird-Try#error1

=== (Done With Tests)
RECV: 16 close
Received command 16
SEND: 16 OK CLOSE completed
SEND: 
System JS : ERROR resource://testing-common/mailnews/maild.js:457
                     NS_BASE_STREAM_CLOSED: Component returned failure code: 0x80470002 (NS_BASE_STREAM_CLOSED) [nsIOutputStream.write]
Connection Lost 2152398850

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

Tested on try server - handle the case where the socket gets closed from under us, but we haven't picked it up yet.

Tested on try server and it passed.

Comment 3

[Joshua Cranmer [:jcranmer]]

Comment on attachment 785902 [details] [diff] [review]
The fix

Review of attachment 785902 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/test/fakeserver/maild.js
@@ +89,4 @@
>   * do_test_finished();
>   *****************************************************************************/
>  function nsMailServer(handlerCreator, daemon) {
> +  this._debug = fsDebugAll;

Did you mean to change the default debug settings to All?

Comment 4

[Mark Banner (:standard8)]

Didn't mean to change the default. I've undone that part of the change and landed it:

https://hg.mozilla.org/comm-central/rev/c96309b77ef8

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 785902 [details] [diff] [review]
The fix

[Triage Comment]
Taking this onto aurora & beta to get this fixed there as well.

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/70f9a67f54c1
https://hg.mozilla.org/releases/comm-beta/rev/c6d489a8ca07