901921 - Nightly OS X build has no menus in menu bar

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Eric Shepherd [:sheppy]]

Attachment: Screen shot of my menu bar

Starting with today's nightly, the menu bar has no items in it, other than the Apple menu and the automatically created "Nightly" menu (which is empty).

"Built from http://hg.mozilla.org/mozilla-central/rev/a0dd80f800e2" according to about:buildconfig.

Comment 1

[Jonathan Kew [:jfkthame]]

Possibly related: the console.log shows several instances of

firefox: Mozilla has caught an Obj-C exception [NSInvalidArgumentException: *** -[__NSArrayM insertObject:atIndex:]: object cannot be nil]

when launching this build.

Interestingly, my local (debug) build of the same changeset does not throw these exceptions, and the menu bar looks fine.

Comment 2

[:Gijs (he/him)]

So, weirdness. I tried to figure this one out and tried these two builds:

Broken: nightly from http://hg.mozilla.org/mozilla-central/rev/a0dd80f800e2
Working: http://hg.mozilla.org/integration/mozilla-inbound/rev/a0dd80f800e2

(yes, these are the same revisions, just on m-i vs. nightly)

I'll check m-c tinderbox (non-nightly) next. Maybe it's related to ifdef'd code?

Comment 3

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #2)
> I'll check m-c tinderbox (non-nightly) next. Maybe it's related to ifdef'd
> code?

The non-nightly version from http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-macosx64/1375759256/ (same cset) works. The Nightly version does not. That's... bad, because we can't really bisect it very easily. :-\

Comment 4

[Axel Hecht [:Pike]]

I wonder if we should disable updates, given how hard this build is to use.

Comment 5

[Jonathan Kew [:jfkthame]]

(In reply to Jonathan Kew (:jfkthame) from comment #1)
> Possibly related: the console.log shows several instances of
> 
> firefox: Mozilla has caught an Obj-C exception [NSInvalidArgumentException:
> *** -[__NSArrayM insertObject:atIndex:]: object cannot be nil]
> 
> when launching this build.

FWIW, these exceptions seem to be thrown when trying to paint the menu bar:

#0  0x00007fff87c729c6 in NSLog ()
#1  0x0000000102344133 in nsMenuBarX::Paint ()
#2  0x000000010235a9a8 in +[WindowDelegate paintMenubarForWindow:] ()
#3  0x000000010235b190 in -[WindowDelegate windowDidBecomeMain:] ()
#4  0x00007fff87c04d0e in __-[NSNotificationCenter addObserver:selector:name:object:]_block_invoke_1 ()
#5  0x00007fff907527ba in _CFXNotificationPost ()
#6  0x00007fff87bf0fc3 in -[NSNotificationCenter postNotificationName:object:userInfo:] ()
#7  0x00007fff8f39627b in -[NSWindow becomeMainWindow] ()
#8  0x00007fff8f396114 in _NXShowKeyAndMain ()
#9  0x00007fff8f2fd629 in -[NSApplication sendEvent:] ()
#10 0x000000010234fa30 in -[GeckoNSApplication sendEvent:] ()
#11 0x00007fff8f294a0e in -[NSApplication run] ()
#12 0x0000000102350c82 in nsAppShell::Run ()
#13 0x000000010219c879 in nsAppStartup::Run ()
#14 0x00000001013745ea in XREMain::XRE_mainRun ()
#15 0x0000000101374851 in XREMain::XRE_main ()
#16 0x0000000101374b67 in XRE_main ()
#17 0x0000000100001f1f in main ()

I suspect they're a -result- rather than a -cause- of the brokenness; the menubar didn't get set up correctly.

Comment 6

[Eric Shepherd [:sheppy]]

(In reply to Axel Hecht [:Pike] from comment #4)
> I wonder if we should disable updates, given how hard this build is to use.

IMHO yes; this is bad juju indeed.

Comment 7

[Andrea Guglielmi]

Same exception just "focusing" the app:
"06/08/13 18:55:22,932 firefox[96963]: Mozilla has caught an Obj-C exception [NSInvalidArgumentException: *** -[__NSArrayM insertObject:atIndex:]: object cannot be nil]"

Comment 10

[Mark Banner (:standard8)]

(In reply to :Gijs Kruitbosch (PTO Aug 8-Aug 18) from comment #3)
> The non-nightly version from
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-
> central-macosx64/1375759256/ (same cset) works. The Nightly version does
> not. That's... bad, because we can't really bisect it very easily. :-\

I've just tried that build and this one:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/08/2013-08-06-03-02-03-mozilla-central/

This one is the nightly build. They both work fine for me.

Updating from the day before to today's nightly does not work.

This feels more like an update issue than a build issue.

Comment 11

[Mark Banner (:standard8)]

I did a diff between an updated nightly and the raw downloaded one. It turns out that the res/ directory is missing. If I copy that from the raw nightly, then the updated one works fine again.

Blame shows this changeset as removing all of res/:

http://hg.mozilla.org/mozilla-central/rev/f87e93861239

which means this is a regression from bug 649607.

Comment 12

[Ed Morley [:emorley]]

Bug 649607 backed out:
remote:   https://hg.mozilla.org/mozilla-central/rev/1e381c91885d

Nightly respun :-)

Comment 13

[Andreas Wagner [:TheOne] [use NI]]

Fixed in respun build: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-06-10-45-38-mozilla-central/

Comment 14

[Axel Hecht [:Pike]]

I got the update, but the build is still broken. Is there anything I can do short of installing from scratch?

Comment 15

[d.a.]

Partial update does not fix the issue. Still missing the menu after updating with about:buildconfig showing it built from: http://hg.mozilla.org/mozilla-central/rev/1e381c91885d

Will probably need a full update to fix it for all nightly users.

Comment 17

[Matthew Bowker]

Still not working after the update.  In fact, now even the built-in "Nightly" menu refuses to work.  

I am unable to re-open the bug, but it has not been fixed.

Comment 18

[:Gavin Sharp [email: [e-mail]]]

I filed bug 902281 to potentially force a full update on Nightly.

Comment 20

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Downloading this build fixed things for me: 

https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-ux/firefox-26.0a1.en-US.mac.dmg

Funnily enough, Firefox was still really useful to me with this issue as I apparently don't really use menus. :)

Comment 21

[Andrew McCreight [:mccr8]]

One way to trigger the update that Blair posted somewhere it this: "put chrome://browser/content/aboutDialog.xul in the urlbar and hit enter."
Then click on the "update" button.