Closed Bug 902328 Opened 10 years ago Closed 7 years ago

Is AudioStream thread-safe?

Categories

(Core :: Audio/Video: MediaStreamGraph, defect, P2)

x86_64
Linux
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: jwwang, Assigned: padenot)

References

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.95 Safari/537.36

Steps to reproduce:

I am tracing code under content/media to learn the global picture of media stream processing and find some interesting facts.

AudioClock::GetPosition() reads mOutRate on state machine thread while AudioClock::SetPlaybackRate() writes to mOutRate on audio thread. How is it thread-safe for no explicit lock is used?
Assignee: nobody → paul
Depends on: 942657
Component: Audio/Video → Audio/Video: MSG/cubeb/GMP
Still relevant?
Flags: needinfo?(padenot)
p2 if it's relevant
Rank: 25
Priority: -- → P2
I think it's been fixed, and in any case, we have plans to remove AudioStream.cpp.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(padenot)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.