Closed Bug 942657 Opened 6 years ago Closed 6 years ago
Stream (and remove MOZ _CUBEB configure option)
We only have a single AudioStream implementation now, but that implementation is spread between the AudioStream abstract class and the BufferedAudioStream concrete class. I've got a patch that flattens the hierarchy down to a single AudioStream class.
Retry with a non-broken base: https://tbpl.mozilla.org/?tree=Try&rev=9667a5b7461c
Another attempt: https://tbpl.mozilla.org/?tree=Try&rev=ed19bb93af0b
Attachment #8337487 - Attachment is obsolete: true
As pushed to try. Main difference in this version is the removal of MOZ_CUBEB, since it's messy to make AudioStream optional when it's non-virtual without littering the rest of the code with MOZ_CUBEB ifdefs and I don't think it makes sense to allow it to be disabled anyway (individual libcubeb backends can be disabled).
Apparently that broken some WebRTC stuff... https://tbpl.mozilla.org/?tree=Try&rev=f0d527368fbc
Attachment #8338167 - Attachment is obsolete: true
Minor fixes vs try version. r? gps for build changes (removing MOZ_CUBEB) r? doublec for everything else.
Comment on attachment 8339752 [details] [diff] [review] bug942657_v3.patch Review of attachment 8339752 [details] [diff] [review]: ----------------------------------------------------------------- r+ covers just the build bits: I can't speak for the sanity of the rest of the patch. ::: configure.in @@ +5546,5 @@ > dnl = Check alsa availability on Linux if using libcubeb > dnl ==================================================== > > dnl If using libcubeb with Linux, ensure that the alsa library is available > +if test "$OS_TARGET" = "Linux"; then The comment above needs updating. @@ +5570,5 @@ > dnl = Disable PulseAudio > dnl ======================================================== > > dnl If using libcubeb with Linux, ensure that the PA library is available > +if test "$OS_TARGET" = "Linux" -a -z "$MOZ_B2G"; then Comment.
Attachment #8339752 - Flags: review?(gps) → review+
Thanks! Landed with configure.in comments fixed: https://hg.mozilla.org/integration/mozilla-inbound/rev/dc9ebdf27e98
Oops, reintroduced a deadlock. Simple fix, pushed again: https://hg.mozilla.org/integration/mozilla-inbound/rev/6c15f3df605a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Summary: Devirtualize AudioStream → Devirtualize AudioStream (and remove MOZ_CUBEB configure option)
You need to log in before you can comment on or make changes to this bug.