902363 - mozL10n.localize() may clear an entire element instead of just the first text node

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Fabien Cazenave [:kaze]]

Consider the following paragraph:

  <p id="test"> This is a test <button>foo</button> </p>

This adds a `data-l10n-id="message"' attribute to #test and keeps the <button> element:

  mozL10n.localize(document.querySelector('#test'), 'message');

This should clear the `data-l10n-id="message"` attribute and the first text node:

  mozL10n.localize(document.querySelector('#test'), 'message');

but it also clears the <button> element, which is not expected.

Comment 1

[Fabien Cazenave [:kaze]]

Attachment: link to pull request

https://github.com/mozilla-b2g/gaia/pull/11397

Comment 2

[Fabien Cazenave [:kaze]]

(In reply to Fabien Cazenave [:kaze] from comment #0)
> This should clear the `data-l10n-id="message"` attribute and the first text
> node:
> 
>   mozL10n.localize(document.querySelector('#test'), 'message');
> 
> but it also clears the <button> element, which is not expected.

Gosh, I need some PTO. *This* should clear the l10n-id attribute and the first text node:

>   mozL10n.localize(document.querySelector('#test'));

Sorry for the confusion (again).

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 786830 [details]
link to pull request

comments on github

please ask me for review again once it's ready :)

Comment 4

[Fabien Cazenave [:kaze]]

Comment on attachment 786830 [details]
link to pull request

Comments addressed.

Comment 5

[Julien Wajsberg [:julienw]]

Comment on attachment 786830 [details]
link to pull request

r=me with the last comment (that you can decide to keep or not)

Comment 6

[Fabien Cazenave [:kaze]]

Merged on master:
https://github.com/mozilla-b2g/gaia/commit/e5154bdd600179bccf1931d0775354cddb31cf43