902421 - |tools srcdir| breaks Firefox startup

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Mihai Sucan [:msucan]]

I just pulled from fx-team and did a build. On startup none of my previous session tabs load, no toolbars are shown, no devtools, almost nothing is loaded. The terminal shows:

JavaScript error: resource://gre/modules/devtools/Loader.jsm, line 76: NS_ERROR_FILE_UNRECOGNIZED_PATH: Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsILocalFile.initWithPath]

I had to manually clear the devtools.loader.srcdir pref to bring Firefox back to life.

Yesterday this command worked well enough - it seems to be a very recent regression. Do we have tests for this command?

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Add correct paths to the SrcdirProvider

Several people have added various paths to the loader without adding an equivalent path to the srcdir version.

I'd love to have a test here, but I am not sure what it would do...  This issue only comes up new files are loaded, so they would not be part of some test, unless the test is trying to require files all over the place, which sounds a bit crazy.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=cf7292b1569d

Comment 3

[Dave Camp (:dcamp)]

Comment on attachment 807966 [details] [diff] [review]
Add correct paths to the SrcdirProvider

Review of attachment 807966 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, testing this is hard.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

https://hg.mozilla.org/integration/fx-team/rev/4ef38d3cfbe2

Comment 5

[Girish Sharma [:Optimizer]]

This is not resolved fixed yet. (until it merges to m-c)

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4ef38d3cfbe2

Comment 7

[Mihai Sucan [:msucan]]

Do we have a bug about adding tests for this stuff? We should make sure such regressions do not happen too often. Thanks!

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Filed bug 919686 to add tests.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Just ran into conflicts from this when uplifting bug 925199 to Aurora. Should we consider landing this there as well?

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

AFAIK, the srcdir feature is only used by Dev Tools contributors, and even then only sometimes, as it has some limitations with what changes will be picked up.  Since it is merely a convenience for faster loading when hacking on the tools locally, I don't think it's necessary to pull this up to Aurora.