902768 - [Buri][STK]No information to user when "alpha ID" is absent or empty within set up call proactive command

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.179
 Firefox os  v1.1
 Mozilla build ID:20130730070228
 
 
 DEFECT DESCRIPTION:
 [STK]No information to user when "alpha ID" is absent or empty within set up call proactive command
 
  REPRODUCING PROCEDURES:
 Load and execute the test applet which "alpha ID" is absent within set up call proactive command. --K.O. No information to the user concerning what is happening when these commands were executed.
 
  EXPECTED BEHAVIOUR:
 as spec 11.14 
  
 - If the first alpha identifier is provided by the SIM and is not a null data object, the ME shall use it during the user confirmation phase. This is also an indication that the ME should not give any other information to the user during the user confirmation phase. If an icon is provided by the SIM, the icon indicated in the command may be used by the ME to inform the user, in addition to, or instead of the alpha identifier, as indicated with the icon qualifier (see subclause 6.5.4). 
 - If the first alpha identifier is not provided by the SIM or is a null data object (i.e. length = '00' and no value part), the ME may give information to the user. 
 - If the second alpha identifier (i.e the one after the mandatory address object) is provided by the SIM and is not a null data object, the ME shall use it during the call set-up phase and during the call. If an icon is provided by the SIM, the icon indicated in the command may be used by the ME to inform the user, in addition to, or instead of the alpha identifier, as indicated with the icon qualifier (see subclause 6.5.4). 
 - If the second alpha identifier is not provided by the SIM or is a null data object (i.e. length = '00' and no value part), the ME may give information to the user.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: QXDM log

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: ADB log

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

What is the 'alpha id'?  What does this bug cause for the user?  How would a user hit this case?  Please elaborate to justify blocking on this.

Comment 6

[buri.blff]

this pr is the GCF case. we need to resolve this pr to pass GCF

Comment 7

[Alex Keybl [:akeybl]]

Fernando, can you take a look? Sounds urgent given comment 6.

Comment 8

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Show default call message if attribute is not provided

Comment 9

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed: https://github.com/mozilla-b2g/gaia/commit/2d482a0c069bded349670e61ec95574afb50124a

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 2d482a0c069bded349670e61ec95574afb50124a to:
v1-train: a293de76ac933e0d406735964dd3b6e9530eaf71

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: a293de76ac933e0d406735964dd3b6e9530eaf71

Comment 12

[buri.blff]

Attachment: main.txt

the log is for:
  the options.confirmMessage has been set icc-confirmCall-defaultmessage, but we can't see the promp;

Comment 13

[buri.blff]

we has test this patch before your given the patch;
we find the options.confirmMessage has been set icc-confirmCall-defaultmessage, but we also can't see the prompt;

Comment 14

[buri.blff]

so, this pr should be reopen;

Comment 15

[buri.blff]

we add some debug log as follow:

'0x10': function STK_CMD_SET_UP_CALL(command, iccManager) {
    function stkSetupCall(confirmed, postMessage) {
      iccManager.responseSTKCommand({
        hasConfirmed: confirmed,
        resultCode: iccManager._icc.STK_RESULT_OK
      });
      if (confirmed && postMessage) {
        //iccManager.alert(postMessage);
        // Transfering the second alpha id to dialer (Bug #873906)
        window.navigator.mozSettings.createLock().set({
          'icc.callmessage': options.callMessage
        });
      }
    }

    var _ = navigator.mozL10n.get;
    DUMP('STK_CMD_SET_UP_CALL:', command.options);
    var options = command.options;
    if ((options.confirmMessage === undefined) ||(options.confirmMessage == '')) {//TCL_guzhenquan modify for pr:502425
      DUMP('STK_CMD_SET_UP_CALL: empty or no alpha id');
      options.confirmMessage = _(
        'icc-confirmCall-defaultmessage', {
          'number': options.address
        });
    }
    DUMP('STK_CMD_SET_UP_CALL: options.confirmMessage:' + options.confirmMessage);
    if (options.confirmMessage) {
      iccManager.asyncConfirm(options.confirmMessage, function(confirmed) {
        stkSetupCall(confirmed, options.callMessage);
      });
    } else {
      stkSetupCall(true, options.callMessage);
    }
  }


asyncConfirm: function(message, callback) {
    if (typeof callback != 'function') {
      callback = function() {};
    }
    if (!this.icc_asyncconfirm) {
      this.icc_asyncconfirm =
        document.getElementById('icc-asyncconfirm');
      this.icc_asyncconfirm_msg =
        document.getElementById('icc-asyncconfirm-msg');
      this.icc_asyncconfirm_btn_no =
        document.getElementById('icc-asyncconfirm-btn-no');
      this.icc_asyncconfirm_btn_yes =
        document.getElementById('icc-asyncconfirm-btn-yes');
    }

    var self = this;
    this.icc_asyncconfirm_btn_no.onclick = function rejectConfirm() {
      self.hideViews();
      callback(false);
    };
    this.icc_asyncconfirm_btn_yes.onclick = function acceptConfirm() {
      self.hideViews();
      callback(true);
    };
    DUMP('asyncConfirm:' + message);
    this.icc_asyncconfirm_msg.textContent = message;
    this.icc_asyncconfirm.classList.add('visible');
    this.icc_view.classList.add('visible');
  },

Maybe this can help you to analis the log

Comment 16

[buri.blff]

According the log, when there is no alpha id, we can see the log DUMP('asyncConfirm:' + message);, but we can't see the promp.

Comment 17

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Hi,

It's working perfect to me in master and v1-train branches. I'll upload a screenshot just now.

(In reply to buri.blff from comment #15)
> we add some debug log as follow:
> 
> '0x10': function STK_CMD_SET_UP_CALL(command, iccManager) {
>     function stkSetupCall(confirmed, postMessage) {
>       iccManager.responseSTKCommand({
>         hasConfirmed: confirmed,
>         resultCode: iccManager._icc.STK_RESULT_OK
>       });
>       if (confirmed && postMessage) {
>         //iccManager.alert(postMessage);
>         // Transfering the second alpha id to dialer (Bug #873906)
>         window.navigator.mozSettings.createLock().set({
>           'icc.callmessage': options.callMessage
>         });
>       }
>     }
> 
>     var _ = navigator.mozL10n.get;
>     DUMP('STK_CMD_SET_UP_CALL:', command.options);
>     var options = command.options;
>     if ((options.confirmMessage === undefined) ||(options.confirmMessage ==
> '')) {//TCL_guzhenquan modify for pr:502425
>       DUMP('STK_CMD_SET_UP_CALL: empty or no alpha id');
>       options.confirmMessage = _(
>         'icc-confirmCall-defaultmessage', {
>           'number': options.address
>         });
>     }
>     DUMP('STK_CMD_SET_UP_CALL: options.confirmMessage:' +
> options.confirmMessage);
>     if (options.confirmMessage) {
>       iccManager.asyncConfirm(options.confirmMessage, function(confirmed) {
>         stkSetupCall(confirmed, options.callMessage);
>       });
>     } else {
>       stkSetupCall(true, options.callMessage);
>     }
>   }
> 
> 
> asyncConfirm: function(message, callback) {
>     if (typeof callback != 'function') {
>       callback = function() {};
>     }
>     if (!this.icc_asyncconfirm) {
>       this.icc_asyncconfirm =
>         document.getElementById('icc-asyncconfirm');
>       this.icc_asyncconfirm_msg =
>         document.getElementById('icc-asyncconfirm-msg');
>       this.icc_asyncconfirm_btn_no =
>         document.getElementById('icc-asyncconfirm-btn-no');
>       this.icc_asyncconfirm_btn_yes =
>         document.getElementById('icc-asyncconfirm-btn-yes');
>     }
> 
>     var self = this;
>     this.icc_asyncconfirm_btn_no.onclick = function rejectConfirm() {
>       self.hideViews();
>       callback(false);
>     };
>     this.icc_asyncconfirm_btn_yes.onclick = function acceptConfirm() {
>       self.hideViews();
>       callback(true);
>     };
>     DUMP('asyncConfirm:' + message);
>     this.icc_asyncconfirm_msg.textContent = message;
>     this.icc_asyncconfirm.classList.add('visible');
>     this.icc_view.classList.add('visible');
>   },
> 
> Maybe this can help you to analis the log

Comment 18

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: device-2013-09-03-100503.png

Comment 19

[buri.blff]

(In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #18)
> Created attachment 798729 [details]
> device-2013-09-03-100503.png

can you give an video?