Open Bug 902925 Opened 13 years ago Updated 5 years ago

Add "Firefox Developer" checkbox to DevTools options panel

Categories

(DevTools :: General, defect, P3)

defect

Tracking

(Not tracked)

People

(Reporter: bgrins, Unassigned)

Details

Attachments

(1 file)

We currently have two Firefox developer specific options in the options panel. With Bug 900500 landing, it would be great to add that to the options as well. Proposal is to replace the two current checkboxes with a single "Firefox Developer" checkbox. Once clicking this checkbox, it will show three below it (and autoselect the first two): ☑ Enable Chrome Debugging ☑ Enable Remote Debugging ☐ Disable Remote Debugging Prompt We should not autoselect "Disable Remote Debugging Prompt", as the user should be making a conscious decision to disable that prompt.
Joe, any thoughts ?
Flags: needinfo?(jwalker)
Sorry Brian, missed this while I was away, and thanks for pointing it out Optimizer. Also +1 for the use of Unicode. So the point of this is to act like an 'Advanced' tab, in effect - to hide the stuff that normal people don't need. Right? I think that's a good goal, and it seems likely to me that we will have more things to put here in the future. We may have a Russian doll here [1], such that: Gecko Developers ⊆ Developer Tools Developers ⊆ Addon Developers ⊆ FxOS App Developers ⊆ Web Developers Maybe in the future we should have this be a slider that surfaces more options the deeper into the rabbit hole/matrix you go. [1]: In case that's a Brit thing: http://en.wikipedia.org/wiki/Matryoshka_doll
Flags: needinfo?(jwalker)
(In reply to Joe Walker [:jwalker] from comment #2) > Sorry Brian, missed this while I was away, and thanks for pointing it out > Optimizer. Also +1 for the use of Unicode. > > So the point of this is to act like an 'Advanced' tab, in effect - to hide > the stuff that normal people don't need. Right? I think that's a good goal, > and it seems likely to me that we will have more things to put here in the > future. > > We may have a Russian doll here [1], such that: > Gecko Developers ⊆ Developer Tools Developers ⊆ Addon Developers ⊆ FxOS App > Developers ⊆ Web Developers > http://bit.ly/13fPoSs What options can you think of at each level (in future) ? Right now I can just think of the addon developer thing which need both remote and chrome settings, so basically there will be nothing extra in addon dev than FxOS dev (currently). and then the 2 above also do not have any specific setting right now.
> ☐ Disable Remote Debugging Prompt Why do we want to expose that? I thought that was essentially for mobile devices. If we want to show this option, that would be only useful for people doing Firefox Desktop remote debugging. Which is not many people at all. We can't even start the server without the command line. So it better be a command line option. And many people will do mobile remote debugging and they might think this option disable the prompt on the device.
(In reply to Paul Rouget [:paul] from comment #4) > > ☐ Disable Remote Debugging Prompt > > Why do we want to expose that? I thought that was essentially for mobile > devices. If we want to show this option, that would be only useful for > people doing Firefox Desktop remote debugging. Which is not many people at > all. We can't even start the server without the command line. So it better > be a command line option. > > And many people will do mobile remote debugging and they might think this > option disable the prompt on the device. Yeah, it might create confusion. We should probably choose a better label if we want to expose it finally.
(In reply to Girish Sharma [:Optimizer] from comment #5) > We should probably choose a better label if we want to expose it finally. If we need a checkbox, it needs to be on the device, not in the devtools. And for security reasons, I'm pretty sure we won't be allowed to add this option as a checkbox in the settings.
(In reply to Paul Rouget [:paul] from comment #6) > (In reply to Girish Sharma [:Optimizer] from comment #5) > > We should probably choose a better label if we want to expose it finally. > > If we need a checkbox, it needs to be on the device, not in the devtools. > And for security reasons, I'm pretty sure we won't be allowed to add this > option as a checkbox in the settings. This setting is anyways applicable only for local remote connections, so its not valid for the device. We should choose a label that clearly explains that or we can put full description in tooltip.
(In reply to Girish Sharma [:Optimizer] from comment #7) > (In reply to Paul Rouget [:paul] from comment #6) > > (In reply to Girish Sharma [:Optimizer] from comment #5) > > > We should probably choose a better label if we want to expose it finally. > > > > If we need a checkbox, it needs to be on the device, not in the devtools. > > And for security reasons, I'm pretty sure we won't be allowed to add this > > option as a checkbox in the settings. > > This setting is anyways applicable only for local remote connections, so its > not valid for the device. We should choose a label that clearly explains > that or we can put full description in tooltip. I may not have been clear about the reasoning for the "Disable Remote Debugging Prompt". To me, a large part of this whole feature is to make it easier for new DevTools contributors and our documentation for them. The remote debugging prompt is an annoying step in the debugging process - if you add a debugger; statement to the DevTools code, in order to actually pause there, you need to restart the browser, mouse up to the tool menu, go to Tools->Web Developer->Browser Debugger, then wait for it to open and select OK (which is not focused by default). This slows down the workflow quite a bit. Even though not many people at all are using any of these features, the proposed UI does hide all of them behind an "Advanced" checkbox, which has a side effect of showing only one "advanced" checkbox to most users (who will never click it), instead of the two that they are currently seeing. Any of the UI aspects like labels and tooltips should be changed if they aren't clear, these were just names I made up.
(In reply to Girish Sharma [:Optimizer] from comment #3) > (In reply to Joe Walker [:jwalker] from comment #2) > > Sorry Brian, missed this while I was away, and thanks for pointing it out > > Optimizer. Also +1 for the use of Unicode. > > > > So the point of this is to act like an 'Advanced' tab, in effect - to hide > > the stuff that normal people don't need. Right? I think that's a good goal, > > and it seems likely to me that we will have more things to put here in the > > future. > > > > We may have a Russian doll here [1], such that: > > Gecko Developers ⊆ Developer Tools Developers ⊆ Addon Developers ⊆ FxOS App > > Developers ⊆ Web Developers > > > > http://bit.ly/13fPoSs > > What options can you think of at each level (in future) ? Right now I can > just think of the addon developer thing which need both remote and chrome > settings, so basically there will be nothing extra in addon dev than FxOS > dev (currently). and then the 2 above also do not have any specific setting > right now. Would the "dynamic reload" and remote tool dogfooding features that have been discussed for the DevTools code base need to be run behind a pref - or would those run behind the 'enable remote debugging' pref? I could see those as being preferences in the UI if they were separate about:config settings. If they were initiated by a command line option or some other way then probably not.
(In reply to Brian Grinstead [:bgrins] from comment #9) > > > We may have a Russian doll here [1], such that: > > > Gecko Developers ⊆ Developer Tools Developers ⊆ Addon Developers ⊆ FxOS App > > > Developers ⊆ Web Developers > > > > > > > http://bit.ly/13fPoSs > > > > What options can you think of at each level (in future) ? Right now I can > > just think of the addon developer thing which need both remote and chrome > > settings, so basically there will be nothing extra in addon dev than FxOS > > dev (currently). and then the 2 above also do not have any specific setting > > right now. > > Would the "dynamic reload" and remote tool dogfooding features that have > been discussed for the DevTools code base need to be run behind a pref - or > would those run behind the 'enable remote debugging' pref? I could see > those as being preferences in the UI if they were separate about:config > settings. If they were initiated by a command line option or some other way > then probably not. Yeah, that would probably work. I was mostly theorizing about what might come though, and not proposing a slider right now. I think a checkbox is the right solution for the current options.
Product: Firefox → DevTools

Harald, WDYT?

Flags: needinfo?(hkirschner)
Severity: normal → S3
Flags: needinfo?(bugzilla)
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: