902934 - Permanent Orange: TEST-UNEXPECTED-FAIL | test_attachment_size.js | logHelper.js | Error console says [stackFrame gApp is not defined

Status: RESOLVED FIXED

(MailNews Core :: Testing Infrastructure, defect)

Description

[Mark Banner (:standard8)]

Seen since we've been fixing the permanent oranges:

https://tbpl.mozilla.org/php/getParsedLog.php?id=26225091&tree=Thunderbird-Beta#error29

TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/mime/test/unit/test_attachment_size.js | test failed (with xpcshell return code: 0), see following log:

TEST-UNEXPECTED-FAIL | ../../../resources/logHelper.js | Error console says [stackFrame gApp is not defined] - See following stack:
JS frame :: ../../../resources/logHelper.js :: _errorConsoleTunnel.observe :: line 63
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

TEST-INFO | (xpcshell/head.js) | exiting test

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix

I think this should fix it. If the blocklist service wants an nsIXULAppInfo in xpcshell tests, then we have to give it one - xpcshell doesn't have a nsIXULAppInfo component.

Whilst here, I'm taking the opportunity to clean up our other nsIXULAppInfo uses to use that nice generic testing module that someone provided.

I've got this running off try server from a comm-beta push:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=6c74575c00ac

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix v2

This time with the needed head_steel.js file and a new Try server spin:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=7394bd8280ea

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/comm-central/rev/e9bab636165b

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 787708 [details] [diff] [review]
The fix v2

[Triage Comment]
This passed on try, so taking straight onto the branches.

Comment 5

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/acbc0c79daa4
https://hg.mozilla.org/releases/comm-beta/rev/a010b1ae5f5d