Permanent Orange: TEST-UNEXPECTED-FAIL | test_attachment_size.js | logHelper.js | Error console says [stackFrame gApp is not defined

RESOLVED FIXED in Thunderbird 26.0

Status

MailNews Core
Testing Infrastructure
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

({intermittent-failure})

Trunk
Thunderbird 26.0
intermittent-failure

Thunderbird Tracking Flags

(thunderbird24 fixed, thunderbird25 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Seen since we've been fixing the permanent oranges:

https://tbpl.mozilla.org/php/getParsedLog.php?id=26225091&tree=Thunderbird-Beta#error29

TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/mime/test/unit/test_attachment_size.js | test failed (with xpcshell return code: 0), see following log:

TEST-UNEXPECTED-FAIL | ../../../resources/logHelper.js | Error console says [stackFrame gApp is not defined] - See following stack:
JS frame :: ../../../resources/logHelper.js :: _errorConsoleTunnel.observe :: line 63
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

TEST-INFO | (xpcshell/head.js) | exiting test
(Assignee)

Comment 1

4 years ago
Created attachment 787579 [details] [diff] [review]
The fix

I think this should fix it. If the blocklist service wants an nsIXULAppInfo in xpcshell tests, then we have to give it one - xpcshell doesn't have a nsIXULAppInfo component.

Whilst here, I'm taking the opportunity to clean up our other nsIXULAppInfo uses to use that nice generic testing module that someone provided.

I've got this running off try server from a comm-beta push:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=6c74575c00ac
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Attachment #787579 - Flags: review?(Pidgeot18)
(Assignee)

Updated

4 years ago
Blocks: 896738
(Assignee)

Updated

4 years ago
Keywords: intermittent-failure
(Assignee)

Comment 2

4 years ago
Created attachment 787708 [details] [diff] [review]
The fix v2

This time with the needed head_steel.js file and a new Try server spin:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=7394bd8280ea
Attachment #787579 - Attachment is obsolete: true
Attachment #787579 - Flags: review?(Pidgeot18)
Attachment #787708 - Flags: review?(Pidgeot18)
Attachment #787708 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/comm-central/rev/e9bab636165b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
(Assignee)

Comment 4

4 years ago
Comment on attachment 787708 [details] [diff] [review]
The fix v2

[Triage Comment]
This passed on try, so taking straight onto the branches.
Attachment #787708 - Flags: approval-comm-beta+
Attachment #787708 - Flags: approval-comm-aurora+
(Assignee)

Comment 5

4 years ago
https://hg.mozilla.org/releases/comm-aurora/rev/acbc0c79daa4
https://hg.mozilla.org/releases/comm-beta/rev/a010b1ae5f5d
status-thunderbird24: --- → fixed
status-thunderbird25: --- → fixed
You need to log in before you can comment on or make changes to this bug.