Last Comment Bug 902934 - Permanent Orange: TEST-UNEXPECTED-FAIL | test_attachment_size.js | logHelper.js | Error console says [stackFrame gApp is not defined
: Permanent Orange: TEST-UNEXPECTED-FAIL | test_attachment_size.js | logHelper....
Status: RESOLVED FIXED
: intermittent-failure
Product: MailNews Core
Classification: Components
Component: Testing Infrastructure (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 26.0
Assigned To: Mark Banner (:standard8)
:
Mentors:
Depends on:
Blocks: 896738
  Show dependency treegraph
 
Reported: 2013-08-08 08:14 PDT by Mark Banner (:standard8)
Modified: 2013-08-09 02:17 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed
fixed


Attachments
The fix (12.09 KB, patch)
2013-08-08 08:19 PDT, Mark Banner (:standard8)
no flags Details | Diff | Splinter Review
The fix v2 (12.32 KB, patch)
2013-08-08 11:50 PDT, Mark Banner (:standard8)
Pidgeot18: review+
standard8: approval‑comm‑aurora+
standard8: approval‑comm‑beta+
Details | Diff | Splinter Review

Description Mark Banner (:standard8) 2013-08-08 08:14:22 PDT
Seen since we've been fixing the permanent oranges:

https://tbpl.mozilla.org/php/getParsedLog.php?id=26225091&tree=Thunderbird-Beta#error29

TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/mime/test/unit/test_attachment_size.js | test failed (with xpcshell return code: 0), see following log:

TEST-UNEXPECTED-FAIL | ../../../resources/logHelper.js | Error console says [stackFrame gApp is not defined] - See following stack:
JS frame :: ../../../resources/logHelper.js :: _errorConsoleTunnel.observe :: line 63
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

TEST-INFO | (xpcshell/head.js) | exiting test
Comment 1 Mark Banner (:standard8) 2013-08-08 08:19:38 PDT
Created attachment 787579 [details] [diff] [review]
The fix

I think this should fix it. If the blocklist service wants an nsIXULAppInfo in xpcshell tests, then we have to give it one - xpcshell doesn't have a nsIXULAppInfo component.

Whilst here, I'm taking the opportunity to clean up our other nsIXULAppInfo uses to use that nice generic testing module that someone provided.

I've got this running off try server from a comm-beta push:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=6c74575c00ac
Comment 2 Mark Banner (:standard8) 2013-08-08 11:50:24 PDT
Created attachment 787708 [details] [diff] [review]
The fix v2

This time with the needed head_steel.js file and a new Try server spin:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=7394bd8280ea
Comment 3 Mark Banner (:standard8) 2013-08-09 02:13:49 PDT
https://hg.mozilla.org/comm-central/rev/e9bab636165b
Comment 4 Mark Banner (:standard8) 2013-08-09 02:15:02 PDT
Comment on attachment 787708 [details] [diff] [review]
The fix v2

[Triage Comment]
This passed on try, so taking straight onto the branches.

Note You need to log in before you can comment on or make changes to this bug.