Status
People
(Reporter: ranbena, Assigned: kgrandon)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(2 attachments)
Evme displays apps when typing their name in the searchbar. Type homescreen/system/keyboard - they appear as installed apps. These apps are being returned by GridManager.getApps(). This happens on master (HIDDEN_ROLES) and not on v1-train (hiddenapps.js)
|
(Assignee) | |
Comment 1•6 years ago
|
||
Created attachment 787962 [details]
Github pull request pointer
Here's a quick patch...
Attachment #787962 -
Flags: review?(21)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 787962 [details]
Github pull request pointer
Sounds good enough to me.
Attachment #787962 -
Flags: review?(21) → review+
|
|
(Assignee) | |
Comment 3•6 years ago
|
||
Landed in master: https://github.com/mozilla-b2g/gaia/commit/9fbd79dd4b5ca44db13219058f5a3036669db78f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
|
(Reporter) | |
Comment 4•6 years ago
|
||
Thanks Kevin. Amir, can you verify this works as expected?
Flags: needinfo?(amirnissim)
|
||
Comment 5•6 years ago
|
||
Homescreen/System/Keyboard are not returned by GridManager.getApps() and does not appear in E.me results - as expected. However, Communications app is returned by getApps() and appears in E.me results but can not be launched.
Flags: needinfo?(amirnissim)
|
|
(Assignee) | |
Comment 6•6 years ago
|
||
Created attachment 792003 [details]
Github Pull Request - Follow up v2
Re-opening the bug and attaching a patch for the follow-up.Assignee: nobody → kgrandon
Status: RESOLVED → REOPENED
Attachment #792003 -
Flags: review?
Resolution: FIXED → ---
|
|
(Assignee) | |
Comment 7•6 years ago
|
||
Comment on attachment 792003 [details]
Github Pull Request - Follow up v2
Cristian - would you be able to give this one a quick review? Thanks!
Attachment #792003 -
Flags: review? → review?(crdlc)
|
||
Comment 8•6 years ago
|
||
Comment on attachment 792003 [details]
Github Pull Request - Follow up v2
Good work, please review one comment on Github, the rest is perfect as usual! Thanks
Attachment #792003 -
Flags: review?(crdlc) → review+
|
|
(Assignee) | |
Comment 9•6 years ago
|
||
Thanks for the awesome reviews. Addressed and landed the follow-up in master: https://github.com/mozilla-b2g/gaia/commit/0a22faefa8010f59a375bd65d5abe4bc6eab7fc6 I also noticed that we're not actually displaying individual apps from entry_points in E.me. I will open up another bug to track this.
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•