Closed Bug 903284 Opened 6 years ago Closed 6 years ago

Change - [l10n] Clarify labels and icons for the contextual appbar

Categories

(Firefox for Metro Graveyard :: App Bar, defect, P2)

x86_64
Windows 8
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 28

People

(Reporter: jwilde, Assigned: TimAbraldes)

References

Details

(Whiteboard: [l10n] [block28] [blocked] feature=change c=tbd u=tbd p=1)

Attachments

(8 files, 5 obsolete files)

61.58 KB, image/png
Details
10.74 KB, application/x-zip-compressed
Details
1.22 KB, image/png
Details
1.89 KB, image/png
Details
11.99 KB, image/png
Details
13.71 KB, application/zip
Details
84.07 KB, patch
TimAbraldes
: review+
Details | Diff | Splinter Review
132.37 KB, image/png
Details
Currently, the labels are a little verbose and unclear. We should change them as follows:

- [Pin to/Unpin from] Top Sites -> Pin on/Unpin on Top Sites
- Unpin from [Bookmarks/History] -> Hide

We need a new icon for the "Hide" label. Yuan has a design in mind for that based on the "Clear selection" icon.

We also need a garbage can icon for "Delete". That's more consistent with Windows 8 styling than the current "X" icon.
Whiteboard: [preview]
we can haz garbage & hide icons?
Flags: needinfo?(shorlander)
We only need "hide" action, not "unhide".
This is come up based on the icon we have for cancelling selection. 

Hope that will help, Stephen
Attachment #788411 - Attachment is patch: false
Summary: Change - Clarify labels and icons for the contextual appbar → [MP] Change - Clarify labels and icons for the contextual appbar
Whiteboard: [preview] → [preview] feature=change c=tbd u=tbd p=0
Whiteboard: [preview] feature=change c=tbd u=tbd p=0 → [preview][blocked] feature=change c=tbd u=tbd p=0
When I backed out part of bug 903283 I accidentally typoed the bug number as 903284. Sorry about that.
Looks like bug 895686 has been updated with icons so I'd like to unblock this one, but I don't think bug 895686 included a 'hide' icon. Do we still need that, Yuan?
Flags: needinfo?(ywang)
I think we do need a "Hide" icon.

We use the "Pin" action for top site tiles, but bookmark and history tiles are not pinned on the canvas. "Hide" is a more appropriate action than "Pin" I think.
Flags: needinfo?(ywang)
No longer blocks: MetroPreviewRelease
Summary: [MP] Change - Clarify labels and icons for the contextual appbar → Change - Clarify labels and icons for the contextual appbar
Whiteboard: [preview][blocked] feature=change c=tbd u=tbd p=0 → [blocked] feature=change c=tbd u=tbd p=0
Whiteboard: [blocked] feature=change c=tbd u=tbd p=0 → [block28] [blocked] feature=change c=tbd u=tbd p=0
No longer depends on: 895686
shorlander has moved on, now we shall unleash the awesomeness of latest addition to metro team!
Flags: needinfo?(shorlander) → needinfo?(mmaslaney)
Assignee: nobody → mmaslaney
Flags: needinfo?(mmaslaney)
Priority: -- → P1
Assignee: mmaslaney → tabraldes
Status: NEW → ASSIGNED
Priority: P1 → P2
QA Contact: jbecerra
Whiteboard: [block28] [blocked] feature=change c=tbd u=tbd p=0 → [block28] [blocked] feature=change c=tbd u=tbd p=1
Attachment #788411 - Attachment mime type: text/plain → application/x-zip-compressed
Marking this as l10n since it involves string changes
Summary: Change - Clarify labels and icons for the contextual appbar → Change - [l10n] Clarify labels and icons for the contextual appbar
Whiteboard: [block28] [blocked] feature=change c=tbd u=tbd p=1 → [l10n] [block28] [blocked] feature=change c=tbd u=tbd p=1
Attached patch Patch v1 (obsolete) — Splinter Review
This patch adds the icons available in bug 895686 and the "hide" icon available in this bug. It makes the "hide" icon appear when bookmarks or history items are selected. It also updates the strings for bookmarks and history items to be "Hide Bookmark" and "Hide," respectively.

Yuan - I'll attach a couple screenshots for you to take a look at.
Attachment #8338973 - Flags: review?(sfoster)
Attachment #8338973 - Flags: feedback?(ywang)
This image shows what the context menu looks like with the patch applied and 1. Bookmarks select, 2. History items selected, and 3. Top sites selected
Comment on attachment 8338973 [details] [diff] [review]
Patch v1

Looks good to me!
Attachment #8338973 - Flags: feedback?(ywang) → feedback+
Attached file icon-contextualAppBar-hide.zip (obsolete) —
Tim, I have made a couple updates to the iconography. There were some visual inconsistencies and rendering issues with the previous set.
Attachment #8335427 - Attachment is obsolete: true
Attached patch With updated hide icon images (obsolete) — Splinter Review
Updating the patch with the fixed hide icons from :mmaslaney, review upcoming
Attachment #8338973 - Attachment is obsolete: true
Attachment #8338973 - Flags: review?(sfoster)
Attachment #8341344 - Flags: review?(sfoster)
Attached patch With updated hide icon images (obsolete) — Splinter Review
Just removing some debug cruft I qref'd by accident. So this just updates Tim's patch by including the latest hide icon images from  attachment 8340887 [details] (icon-contextualAppBar-hide.zip)
Attachment #8341344 - Attachment is obsolete: true
Attachment #8341344 - Flags: review?(sfoster)
Attachment #8341348 - Flags: review?(sfoster)
Comment on attachment 8341348 [details] [diff] [review]
With updated hide icon images

Review of attachment 8341348 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I've not been about to see and test the hi-rez icons, but from what I can tell they look right.
Attachment #8341348 - Flags: review?(sfoster) → review+
Updating tests to no longer break with patch applied. Carrying forward r+
Attachment #8341348 - Attachment is obsolete: true
Attachment #8342006 - Flags: review+
Is this all ready to go?
yup! This is ready to land. I was hoping to land it along with other changes. I'll just mark checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/9e45b2101381
Keywords: checkin-needed
Whiteboard: [l10n] [block28] [blocked] feature=change c=tbd u=tbd p=1 → [l10n] [block28] [blocked] feature=change c=tbd u=tbd p=1[fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/9e45b2101381
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [l10n] [block28] [blocked] feature=change c=tbd u=tbd p=1[fixed-in-fx-team] → [l10n] [block28] [blocked] feature=change c=tbd u=tbd p=1
Target Milestone: --- → Firefox 28
Attached image screenshot_it build.png
- on Win 8 64-bit

Verified as fixed, for iteration #20, with latest en-US Nightly (build ID: 20131209053402): the context menu looks like here: https://bug903284.bugzilla.mozilla.org/attachment.cgi?id=8338977. Also, I can see the expected icons for the 4 search providers: Google, Bing, Yahoo and Wikipedia

On the other hand, with the it Nightly build from ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/12/2013-12-09-05-34-02-mozilla-central-l10n/ the icons for Amazon and Yahoo aren't the same as the ones attached in a .zip file, previously in this bug. (please see the attached screenshot for details)

Is this expected?
Flags: needinfo?(tabraldes)
(In reply to Manuela Muntean [:Manuela] [QA] from comment #26)
> Created attachment 8345269 [details]
> screenshot_it build.png
> 
> - on Win 8 64-bit
> 
> Verified as fixed, for iteration #20, with latest en-US Nightly (build ID:
> 20131209053402): the context menu looks like here:
> https://bug903284.bugzilla.mozilla.org/attachment.cgi?id=8338977. Also, I
> can see the expected icons for the 4 search providers: Google, Bing, Yahoo
> and Wikipedia
> 
> On the other hand, with the it Nightly build from
> ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/12/2013-12-09-05-
> 34-02-mozilla-central-l10n/ the icons for Amazon and Yahoo aren't the same
> as the ones attached in a .zip file, previously in this bug. (please see the
> attached screenshot for details)
> 
> Is this expected?

I honestly don't know if that's expected or not. I didn't actually change the search provider icons as part of this bug because we seemed to already be using the right icons when I started working on this. We should file a new bug if any of our search provider icons seem like they aren't right (in any builds).
Flags: needinfo?(tabraldes)
Marking this as verified, based on comment 26.

I thought the search provider icons where changed as part of this bug, because of the .zip file attached here: https://bugzilla.mozilla.org/attachment.cgi?id=788411

Tim: regarding your previous comment (comment 27), I've logged bug 949521 and CC'ed you among others.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.