903284 - Change - [l10n] Clarify labels and icons for the contextual appbar

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: App Bar, defect, P2)

Description

[Jonathan Wilde [:jwilde]]

Currently, the labels are a little verbose and unclear. We should change them as follows:

- [Pin to/Unpin from] Top Sites -> Pin on/Unpin on Top Sites
- Unpin from [Bookmarks/History] -> Hide

We need a new icon for the "Hide" label. Yuan has a design in mind for that based on the "Clear selection" icon.

We also need a garbage can icon for "Delete". That's more consistent with Windows 8 styling than the current "X" icon.

Comment 1

[Allison Naaktgeboren :ally]

we can haz garbage & hide icons?

Comment 2

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Attachment: [Sketch] idea for hide icon

We only need "hide" action, not "unhide".
This is come up based on the icon we have for cancelling selection. 

Hope that will help, Stephen

Comment 3

[Jonathan Wilde [:jwilde]]

Attachment: Search provider icons.zip

Comment 4

[[e-mail]]

When I backed out part of bug 903283 I accidentally typoed the bug number as 903284. Sorry about that.

Comment 5

[Marina Samuel [:emtwo]]

Looks like bug 895686 has been updated with icons so I'd like to unblock this one, but I don't think bug 895686 included a 'hide' icon. Do we still need that, Yuan?

Comment 6

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

I think we do need a "Hide" icon.

We use the "Pin" action for top site tiles, but bookmark and history tiles are not pinned on the canvas. "Hide" is a more appropriate action than "Pin" I think.

Comment 7

[Allison Naaktgeboren :ally]

shorlander has moved on, now we shall unleash the awesomeness of latest addition to metro team!

Comment 8

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: icon-contextualAppBar-delete.png

Comment 9

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: [e-mail]

Comment 10

[Michael Maslaney [:mmaslaney] ([e-mail])]

Hide icon to come.

Comment 11

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: icon-contextualAppBar-Hide.zip

Comment 12

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Marking this as l10n since it involves string changes

Comment 13

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: Patch v1

This patch adds the icons available in bug 895686 and the "hide" icon available in this bug. It makes the "hide" icon appear when bookmarks or history items are selected. It also updates the strings for bookmarks and history items to be "Hide Bookmark" and "Hide," respectively.

Yuan - I'll attach a couple screenshots for you to take a look at.

Comment 14

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: Screenshot with patch v1 applied

This image shows what the context menu looks like with the patch applied and 1. Bookmarks select, 2. History items selected, and 3. Top sites selected

Comment 15

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Comment on attachment 8338973 [details] [diff] [review]
Patch v1

Looks good to me!

Comment 16

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: icon-contextualAppBar-hide.zip

Tim, I have made a couple updates to the iconography. There were some visual inconsistencies and rendering issues with the previous set.

Comment 17

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: icon-contextualAppBar-hide.zip

Comment 18

[Sam Foster [:sfoster] (he/him)]

Attachment: With updated hide icon images

Updating the patch with the fixed hide icons from :mmaslaney, review upcoming

Comment 19

[Sam Foster [:sfoster] (he/him)]

Attachment: With updated hide icon images

Just removing some debug cruft I qref'd by accident. So this just updates Tim's patch by including the latest hide icon images from  attachment 8340887 [details] (icon-contextualAppBar-hide.zip)

Comment 20

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8341348 [details] [diff] [review]
With updated hide icon images

Review of attachment 8341348 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I've not been about to see and test the hi-rez icons, but from what I can tell they look right.

Comment 21

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: Patch v4 - fixes tests

Updating tests to no longer break with patch applied. Carrying forward r+

Comment 22

[Jim Mathies [:jimm]]

Is this all ready to go?

Comment 23

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

yup! This is ready to land. I was hoping to land it along with other changes. I'll just mark checkin-needed

Comment 24

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/9e45b2101381

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9e45b2101381

Comment 26

[Manuela Muntean [Away]]

Attachment: screenshot_it build.png

- on Win 8 64-bit

Verified as fixed, for iteration #20, with latest en-US Nightly (build ID: 20131209053402): the context menu looks like here: https://bug903284.bugzilla.mozilla.org/attachment.cgi?id=8338977. Also, I can see the expected icons for the 4 search providers: Google, Bing, Yahoo and Wikipedia

On the other hand, with the it Nightly build from ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/12/2013-12-09-05-34-02-mozilla-central-l10n/ the icons for Amazon and Yahoo aren't the same as the ones attached in a .zip file, previously in this bug. (please see the attached screenshot for details)

Is this expected?

Comment 27

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

(In reply to Manuela Muntean [:Manuela] [QA] from comment #26)
> Created attachment 8345269 [details]
> screenshot_it build.png
> 
> - on Win 8 64-bit
> 
> Verified as fixed, for iteration #20, with latest en-US Nightly (build ID:
> 20131209053402): the context menu looks like here:
> https://bug903284.bugzilla.mozilla.org/attachment.cgi?id=8338977. Also, I
> can see the expected icons for the 4 search providers: Google, Bing, Yahoo
> and Wikipedia
> 
> On the other hand, with the it Nightly build from
> ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/12/2013-12-09-05-
> 34-02-mozilla-central-l10n/ the icons for Amazon and Yahoo aren't the same
> as the ones attached in a .zip file, previously in this bug. (please see the
> attached screenshot for details)
> 
> Is this expected?

I honestly don't know if that's expected or not. I didn't actually change the search provider icons as part of this bug because we seemed to already be using the right icons when I started working on this. We should file a new bug if any of our search provider icons seem like they aren't right (in any builds).

Comment 28

[Manuela Muntean [Away]]

Marking this as verified, based on comment 26.

I thought the search provider icons where changed as part of this bug, because of the .zip file attached here: https://bugzilla.mozilla.org/attachment.cgi?id=788411

Tim: regarding your previous comment (comment 27), I've logged bug 949521 and CC'ed you among others.