903443 - First time users get two overlapping tips

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

Reset the phone (v1-train) and click the keyboard.
You get one tip for first time opening Evme and one for first time using the searchbar.

Comment 1

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Patch - redirect to github PR.html

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Notice, this PR is not for the master branch, for it has no Tips (Bug 879292). It'll relevant and should be merged into v1-train only.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 788183 [details] [diff] [review]
Patch - redirect to github PR.html

Small code removals.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This is a regression coming from the move to the left to the landing page.

Before e.me was showing a tip the first time the user shown the e.me page *and* a tip when the user click on the search field the first time.

But now both actions are the same. The user enter everything.me the first time by click the search field. The actual patch is to remove one of those tip (it removes just the display of the tip, not the underlying code)

Comment 5

[David Scravaglieri [:scravag]]

Make sense with the requirement for e.me in the landing page. Not having it would result in a bad user experience.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

v1-train:
https://github.com/mozilla-b2g/gaia/commit/691a9214e3d009d76e1f91ca288c54064288ab4c

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 691a9214e3d009d76e1f91ca288c54064288ab4c

Comment 8

[Chris Kreinbring [:CKreinbring]]

This appears to fixed on the Leo 1.1 commercial RIL.  Tapping the search bar brings up only one tip.

Build ID: 20130814041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/15813d776a69
Gaia: dd3959fa74e356a528daa76ffee14c2c728a4b56
Platform Version: 18.1
RIL Version: 01.01.00.019.190