903473 - Regression: DuckDuckGo Goodies content hidden behind the address-bar when the dynamic toolbar is enabled; site interaction broken

Status: RESOLVED DUPLICATE of bug 923969

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Visit http://duckduckgo.com/goodies on Nightly (26.0) and or Aurora (25.0) and see how their header is stuck behind our address-bar. Attempt to touch any tab to change the content of the page and it's seemingly difficult if not possible. 

Disabling the dynamic-toolbar resolves this issue.  

--
Nightly (08/09) | Aurora (08/09)

Comment 1

[Teodora Vermesan (:TeoVermesan)]

The regression window is:

1.mozilla-central
good build: 22.07.2013 
bad build: 23.07.2013 
-pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2268ff80683a&tochange=5ceea82a79c7

2.inbound
good build:1374479809
bad build: 1374483050
-pushlog: 
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=646cba66eb0c&tochange=c6f2fd048e62

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

feel free to hand off if there is a better assignee

Comment 3

[Kartikaya Gupta (email:[e-mail])]

This one is interaction between fixed-position code and dynamic toolbar. Cwiiis is the best person to look at this. I don't understand the fixed-position code at all, even though I kinda sorta understand the dynamic toolbar parts now.

Comment 4

[Aaron Train [:aaronmt]]

Resetting assignee while Chris is out as this will be on Beta soon.

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

blassey can you find an owner?

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Roc, sounds like this might be a regression from your fixed-position rewrite. Is there someone on your team that knows this code well enough to investigate?

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I haven't landed the fixed-pos rewrite yet.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Actually, let me flip this back to kats since if I fix it, he'll have to review it and learn the fixed-pos margins code anyway :-). Kats, we can work on this together tomorrow if you like.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

We tried repro'ing this now but couldn't. Tested on both Galaxy Q and Nexus 4 running recent builds. There is some weirdness with the scrolling but it feels like the page is not handling touch events properly. At any rate the issue in this bug is no longer present so closing as WFM.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Making this a dupe of bug 923969 which is the same underlying problem. There is some discussion there about what fixed this and whether or not it should be uplifted.