903528 - Adapt services' JUnit unit testing framework to Fennec

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The android background services team has one test suite for unit testing, which runs locally on desktop, and another test suite for integration testing, which runs on Android devices.

For mobile front-end, robocop serves the purpose of the integration test suite, however, the capabilities for unit testing are lacking.

Bug 709353 will integrate services' JUnit testing framework into the automated testing systems - at that point, we should piggy-back on these efforts and adapt it to work for Fennec.

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to Michael Comella (:mcomella) from comment #0)
> The android background services team has one test suite for unit testing,
> which runs locally on desktop, and another test suite for integration
> testing, which runs on Android devices.

To add some details: the unit testing suite is JUnit 4 and requires the Java runtime to execute; the integration testing suite is JUnit 3.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Note that bug 856614 is similar and perhaps should be duped.

Comment 3

[Richard Newman [:rnewman]]

Starting to track Fennec tests that would be 1/5 the size if implemented on JUnit:

Bug 834033

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: Land and build Fennec JUnit 3 tests. r=mfinkle

WIP for mcomella.

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: Pre: Make classes.dex depend on ANDROID_EXTRA_JARS. r=glandium

This has already been reviewed by glandium; will carry-forward the r+.

Comment 6

[Nick Alexander :nalexander [he/him]]

Attachment: Part 1: Rename background.apk to background-junit3.apk. r=rnewman

This is a cautionary move: when uploaded to infrastructure,
background.apk will not look so bad; but browser.apk is likely to
confuse folks. (These files will be in the same directory as
fennec-*apk, and sort earlier than that file.)

I considered including "tests" in the name, but decided not to make a
long name even longer.

This also renames the Android package. This is purely cosmetic, since
the package has no consumers (infrastructure, mach, etc). But this looks
nicer in IDEs: the generated classes fit into the class hierarchy.

Comment 7

[Nick Alexander :nalexander [he/him]]

Attachment: Part 2: Land and build Fennec JUnit 3 tests. r=rnewman

The meat. Tested against my local device using Eclipse. Try build coming.

Comment 8

[Nick Alexander :nalexander [he/him]]

Attachment: Post: Add Eclipse project data to moz.build. r=rnewman

Comment 9

[Nick Alexander :nalexander [he/him]]

This is looking fine:

https://tbpl.mozilla.org/?tree=Try&rev=eb154f0de5eb

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8375799 [details] [diff] [review]
Land and build Fennec JUnit 3 tests. r=mfinkle

Assuming that I'm no longer needed here - reflag me if that's not the case.

Comment 11

[Richard Newman [:rnewman]]

Comment on attachment 8380227 [details] [diff] [review]
Part 2: Land and build Fennec JUnit 3 tests. r=rnewman

Review of attachment 8380227 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but consider whether you want these tests to be 2- or 4-spaced. You've got them as 2-spaced right now.

::: mobile/android/tests/browser/junit3/Makefile.in
@@ +5,5 @@
> +ANDROID_APK_NAME := browser-junit3-debug
> +
> +ANDROID_EXTRA_JARS += \
> +	browser-junit3.jar \
> +  $(NULL)

Indenting.

::: mobile/android/tests/browser/junit3/src/harness/BrowserInstrumentationTestRunner.java
@@ +28,5 @@
> +    Log.d(LOG_TAG, "getAndroidTestRunner");
> +		AndroidTestRunner testRunner = super.getAndroidTestRunner();
> +		testRunner.addTestListener(new BrowserTestListener());
> +		return testRunner;
> +	}

Indenting.

::: mobile/android/tests/browser/junit3/src/harness/BrowserTestListener.java
@@ +14,5 @@
> + * <p>
> + * The idea is that, on infrastructure, we'll be able to use the same test
> + * parsing code for Browser JUnit 3 tests as we do for Robocop tests.
> + * <p>
> + * In future, that is!

Bug filed for this?

Comment 12

[Richard Newman [:rnewman]]

Comment on attachment 8380228 [details] [diff] [review]
Post: Add Eclipse project data to moz.build. r=rnewman

Review of attachment 8380228 [details] [diff] [review]:
-----------------------------------------------------------------

This is the most rubberstampy of rubberstamps.

Comment 13

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/f0e73c266048
https://hg.mozilla.org/integration/fx-team/rev/b57e246db50b
https://hg.mozilla.org/integration/fx-team/rev/51c20dd62b11
https://hg.mozilla.org/integration/fx-team/rev/9d6e281584dc

Comment 14

[Nick Alexander :nalexander [he/him]]

Looks like my moz.build AndroidEclipse data needed to be bumped:

https://hg.mozilla.org/integration/fx-team/rev/a7f45c95831d

Comment 15

[Nick Alexander :nalexander [he/him]]

Looks like there are some pre-existing build dependency problems that this patch tickles:

https://hg.mozilla.org/integration/fx-team/rev/78e1e8346461

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f0e73c266048
https://hg.mozilla.org/mozilla-central/rev/b57e246db50b
https://hg.mozilla.org/mozilla-central/rev/51c20dd62b11
https://hg.mozilla.org/mozilla-central/rev/9d6e281584dc
https://hg.mozilla.org/mozilla-central/rev/a7f45c95831d
https://hg.mozilla.org/mozilla-central/rev/78e1e8346461