903714 - "uri is undefined" when calling method nsIWebContentHandlerRegistrar::registerProtocolHandler() on www.irccloud.com

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Everytime I open a tab with www.irccloud.com I see an error message saying:

* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "uri is undefined" {file: "objdir-ff-release/dist/Nightly.app/Contents/MacOS/browser/components/WebContentConverter.js" line: 412}]' when calling method: [nsIWebContentHandlerRegistrar::registerProtocolHandler]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: https://www.irccloud.com/static/js/app.combined.min.js?v=9827ae3c908d1d225c8f19ddc8576d28 :: SessionView<.registerProtocolHandlers :: line 5"  data: yes]

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

_makeURI() called by _checkAndGetURI() throws:

http://mxr.mozilla.org/mozilla-central/source/browser/components/feeds/src/WebContentConverter.js#313

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Provide document.baseURI when calling _makeURI() in registerProtocolHandler()

IRCCloud calls registerProtocolHandler(irc,#?/irc_url=%s,IRCCloud) which seems like it should be allowed but does of course only work as long as we provide the baseURI to _makeURI().

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/a902370b74af

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Backed out for m1 failures:

https://hg.mozilla.org/integration/fx-team/rev/a0114f95b034

ERROR TEST-UNEXPECTED-FAIL | /tests/browser/components/feeds/test/test_registerHandler.html | a protocol handler uri should be valid - got false, expected true
ERROR TEST-UNEXPECTED-FAIL | /tests/browser/components/feeds/test/test_registerHandler.html | a content handler uri should be valid - got false, expected true

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Provide document.baseURI when calling _makeURI() in registerProtocolHandler(), v2

Fixed tests.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

You can use doc.baseURIObject to avoid needing to call makeURI

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #6)
> You can use doc.baseURIObject to avoid needing to call makeURI

Nice.

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Provide document.baseURI when calling _makeURI() in registerProtocolHandler(), v3

Following Gavin's suggestion.

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

Try looks good:

https://tbpl.mozilla.org/?tree=Try&rev=36c0a29f8224

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/f8fe45a1f17a

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f8fe45a1f17a

Comment 12

[Tom S. (please needinfo tschuster)]

Every-time I go to irccloud now I see a message: "IRCCload has already been added as an application for irc links". That is super annoying.

Comment 13

[Tim Taubert [:ttaubert] (inactive)]

I will certainly not apologize for fixing this ;) But I see the same issue and we should file another bug and fix that as well. Not sure why we even have that notification as that should just be ignored, imo.

Comment 14

[Tom S. (please needinfo tschuster)]

Of course not, thanks for fixing this! The console message was distracting me as well.