903844 - Add/update iwyu annotations for various files

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

ehsan for xpcom/profiler; khuey for content/dom/makefile changes.

Comment 1

[Nicholas Nethercote [inactive]]

Comment on attachment 788664 [details] [diff] [review]
Patch v1

Review of attachment 788664 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/public/nsVKList.h
@@ +2,2 @@
>  /* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
>  /* vim: set ts=2 et sw=2 tw=80: */

I have |set modelines=2| in my .vimrc, which means "look for a Vim modeline in the first two lines of a file".  This change will break that.

Of course, I could change it from 2 to 3.  But futzing with the standard file header seems less than ideal.  Can the IWYU pragma be moved down, preferably after the license block?

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Sure.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 788664 [details] [diff] [review]
Patch v1

Review of attachment 788664 [details] [diff] [review]:
-----------------------------------------------------------------

The makefile change looks fine.  I'm assuming ehsan reviewed the IWYU stuff since I have no idea what it does.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/0baf6eca3e3b