Closed Bug 903844 Opened 8 years ago Closed 8 years ago

Add/update iwyu annotations for various files

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla26

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Patch v1
22.13 KB, patch
ehsan.akhgari
: review+
khuey
: review+
Details | Diff | Splinter Review
Attached patch Patch v1 — — Splinter Review 
ehsan for xpcom/profiler; khuey for content/dom/makefile changes.
Attachment #788664 - Flags: review?(khuey)
Attachment #788664 - Flags: review?(ehsan)
Comment on attachment 788664 [details] [diff] [review]
Patch v1

Review of attachment 788664 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/public/nsVKList.h
@@ +2,2 @@
>  /* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
>  /* vim: set ts=2 et sw=2 tw=80: */

I have |set modelines=2| in my .vimrc, which means "look for a Vim modeline in the first two lines of a file".  This change will break that.

Of course, I could change it from 2 to 3.  But futzing with the standard file header seems less than ideal.  Can the IWYU pragma be moved down, preferably after the license block?
Sure.
Attachment #788664 - Flags: review?(ehsan) → review+
Comment on attachment 788664 [details] [diff] [review]
Patch v1

Review of attachment 788664 [details] [diff] [review]:
-----------------------------------------------------------------

The makefile change looks fine.  I'm assuming ehsan reviewed the IWYU stuff since I have no idea what it does.
Attachment #788664 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/0baf6eca3e3b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.