test_imgtools should use do_get_tempdir()

RESOLVED FIXED in mozilla26

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mihneadb, Assigned: mihneadb)

Tracking

unspecified
mozilla26
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Right now it uses a hardcoded "/tmp" path.

This might also help with bug 676968.
(Assignee)

Comment 1

5 years ago
Created attachment 788699 [details] [diff] [review]
make test_imgtools use do_get_tempdir()
Attachment #788699 - Flags: review?(joe)
(Assignee)

Updated

5 years ago
Assignee: nobody → mihneadb
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Blocks: 887064
Attachment #788699 - Flags: review?(joe) → review?(dolske)
Comment on attachment 788699 [details] [diff] [review]
make test_imgtools use do_get_tempdir()

This code shouldn't ever be run in automation, it's just a convenience for developers locally testing. But this change is fine.
Attachment #788699 - Flags: review?(dolske) → review+
(Assignee)

Comment 3

5 years ago
Thanks
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/73cfa2df72c8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.