903902 - [System] Remove unnecessary DEVICE_RATIO from window_manager.js

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

Regression of bug 893710.

It's no necessary to multiply deviceRatio with iframe's width and height for screenshot in window_manager.js, so this bug is to remove it in case for any side effect and confusion.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to v1.1.0hd

This patch is to fix regression of bug 893710.

It's no necessary to multiply deviceRatio for iframe's offsetWidth and offsetHeight in css pixel. 

I also took some screenshots with/without changes, the resolutions are the same.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

The iframe's offsetWidth and offsetHeight are already 320 and 533 in window_manager.js, so it should be unnecessary for window_manager.js.

Comment 3

[Wayne Chang [:wchang]]

HD+ for regression on the branch.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Merge into v1.1.0hd,
https://github.com/mozilla-b2g/gaia/commit/1c771afe45c97616c4207fbe475e97739d460bf6

Comment 5

[Al Tsai [:atsai]]

[2013/10/21 Helix Testing]
Gaia:     c829a2042594b6c3a4899ee27979799a0f301534
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f7c657f6d019
BuildID   20131015042201
Version   18.0