903919 - [Flatfish][Gallery] add support for large device

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

Expect:

Modify and Merge experiment tablet work from 

https://github.com/gaia-local/gaia

to master

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Gallery.png

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Crop.png

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Display.png

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Effects.png

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Exposure.png

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

add support for landscape mode

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: after patch, grid, landscape

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: after patch, grid, portrait

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: after patch, effect, landscape

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: after patch, fullscreen, landscape

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 791954 [details]
PR to master

This patch has done below things for tablet version (it will not affect mobile version).
1. 4 pictures per row for portrait, 6 for landscape
2. enlarge toobar and font

I already attached screenshots after this patch, please also kindly check.

Comment 12

[David Flanagan [:djf]]

Comment on attachment 791954 [details]
PR to master

I think there are a couple of unnecessary styles in gallery-large.css, so please check that before landing.

Otherwise, it looks good.  I didn't know you could apply media queries to link elements. That is a really nice way to load device-specific styles!

Comment 13

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thank you!

Merge into master,
https://github.com/mozilla-b2g/gaia/commit/693af4e4c936eed0c580ba0cc6d78b343af44202

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

I found 4th pic in landscape mode has 0 right-margin, which make the layout wired. So, I revert it by my self.

Comment 15

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi David,

This patch has added below code into gallery_large.css and other part doesn't change. Please kindly review. Thanks.

@media (orientation: landscape) {
  .thumbnail:nth-child(4n) {
    margin-right: 0.4rem;
  }
}

Comment 16

[David Flanagan [:djf]]

Comment on attachment 805711 [details]
PR to master

Ah. You need the 4n setting to override the landscape layout for smaller screen sizes, don't you?  I'd suggest you add a comment to the css about that because otherwise it looks like a mistake.

I suppose eventually we ought to use media queries for each separate screen resolution in this app so that only one file is loaded and we don't have to override things.

But this is okay for now.

Comment 17

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks David, comment added.

Merged into master,
https://github.com/mozilla-b2g/gaia/commit/77b1393ee3a7db1550daafa7ae855bc8094b9c72

Comment 18

[James Lal [:lightsofapollo]]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 77b1393ee3a7db1550daafa7ae855bc8094b9c72
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 19

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks James.

This bug has some small bug, so I revert it from master and push again.
I will revert it and push to v1.2.

Comment 20

[(Inactive after June) George Duan [:gduan] [:喬智]]

Revert original patch,
https://github.com/mozilla-b2g/gaia/commit/8856dda7a1fa4b9f1c961cad3e915d2ba471db44#diff-f62de2b1ff35d1547e0d1ee394fcf092

Merge into v1.2,
https://github.com/mozilla-b2g/gaia/commit/def8e152db6a317162c03a316f68c409f3af3979