Closed Bug 903919 Opened 7 years ago Closed 6 years ago

[Flatfish][Gallery] add support for large device

Categories

(Firefox OS Graveyard :: Gaia::Gallery, defect)

x86
macOS
defect
Not set

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

RESOLVED FIXED
blocking-b2g koi+
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: gduan, Assigned: gduan)

References

Details

(Whiteboard: QARegressExclude)

Attachments

(10 files, 1 obsolete file)

Expect:

Modify and Merge experiment tablet work from 

https://github.com/gaia-local/gaia

to master
Assignee: nobody → gduan
Blocks: flatfish
blocking-b2g: --- → koi+
Attached file PR to master (obsolete) —
add support for landscape mode
Comment on attachment 791954 [details]
PR to master

This patch has done below things for tablet version (it will not affect mobile version).
1. 4 pictures per row for portrait, 6 for landscape
2. enlarge toobar and font

I already attached screenshots after this patch, please also kindly check.
Attachment #791954 - Flags: review?(dflanagan)
Comment on attachment 791954 [details]
PR to master

I think there are a couple of unnecessary styles in gallery-large.css, so please check that before landing.

Otherwise, it looks good.  I didn't know you could apply media queries to link elements. That is a really nice way to load device-specific styles!
Attachment #791954 - Flags: review?(dflanagan) → review+
Thank you!

Merge into master,
https://github.com/mozilla-b2g/gaia/commit/693af4e4c936eed0c580ba0cc6d78b343af44202
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
I found 4th pic in landscape mode has 0 right-margin, which make the layout wired. So, I revert it by my self.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached file PR to master
Hi David,

This patch has added below code into gallery_large.css and other part doesn't change. Please kindly review. Thanks.

@media (orientation: landscape) {
  .thumbnail:nth-child(4n) {
    margin-right: 0.4rem;
  }
}
Attachment #791954 - Attachment is obsolete: true
Attachment #805711 - Flags: review?(dflanagan)
Comment on attachment 805711 [details]
PR to master

Ah. You need the 4n setting to override the landscape layout for smaller screen sizes, don't you?  I'd suggest you add a comment to the css about that because otherwise it looks like a mistake.

I suppose eventually we ought to use media queries for each separate screen resolution in this app so that only one file is loaded and we don't have to override things.

But this is okay for now.
Attachment #805711 - Flags: review?(dflanagan) → review+
Thanks David, comment added.

Merged into master,
https://github.com/mozilla-b2g/gaia/commit/77b1393ee3a7db1550daafa7ae855bc8094b9c72
Status: REOPENED → RESOLVED
Closed: 7 years ago6 years ago
Resolution: --- → FIXED
I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 77b1393ee3a7db1550daafa7ae855bc8094b9c72
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(gduan)
Thanks James.

This bug has some small bug, so I revert it from master and push again.
I will revert it and push to v1.2.
Flags: needinfo?(gduan)
Whiteboard: QARegressExclude
You need to log in before you can comment on or make changes to this bug.