Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Status

()

bugzilla.mozilla.org
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: glob, Assigned: glob)

Tracking

Production
x86
Mac OS X

Details

Attachments

(3 attachments)

(Assignee)

Description

4 years ago
Created attachment 788793 [details] [diff] [review]
gravatar_1.patch

gravatars look nice in the mozilla skin, and work well to break up the page.

i'd like to add gravatar support, and make it enabled by default at the same time we switch the default skin to Mozilla.


the attached patch does that, as well as adding a 'bz_gravatar' class to <body> for bugzillajs.
Attachment #788793 - Flags: review?(dkl)
(Assignee)

Comment 1

4 years ago
Created attachment 788799 [details]
Screen Shot 2013-08-09 at 1.31.35 PM.png
Instead of the default gravatar image, we should supply our own... Maybe a dino head?
(Assignee)

Comment 3

4 years ago
(In reply to Reed Loden [:reed] from comment #2)
> Instead of the default gravatar image, we should supply our own.
> Maybe a dino head?

the dino head has been retired.
see the bottom of http://www.mozilla.org/en-US/styleguide/identity/mozilla/branding/

perhaps the mm graphic would be better:
http://www.gravatar.com/avatar/?f=y&d=mm&s=32
Comment on attachment 788793 [details] [diff] [review]
gravatar_1.patch

Review of attachment 788793 [details] [diff] [review]:
-----------------------------------------------------------------

Need to create a extensions/Gravatar/template/en/default/hook/global/setting-descs-settings.none.tmpl file as well for showing a description for the new user settings.

For example:

[%# This Source Code Form is subject to the terms of the Mozilla Public
  # License, v. 2.0. If a copy of the MPL was not distributed with this
  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
  #
  # This Source Code Form is "Incompatible With Secondary Licenses", as
  # defined by the Mozilla Public License, v. 2.0.
  #%]

[%
  setting_descs.show_gravatars = "When viewing a $terms.bug, display gravatar images next to user logins."
%]

Also please fix the spacing between the user name and the comment box by closing the gap. This is not related
to this patch but is more noticeable when gravatar support is enabled. If you look at changes only type comment
blocks, the gravatar image is almost connected to the bounding box where for normal comments, the gap is much wider.
I will attach a screenshot to better illustrate.

Fix the two above on commit. r=dkl
dkl
the
Created attachment 789795 [details]
Screenshot from 2013-08-13 16:29:59.png

Updated

4 years ago
Attachment #788793 - Flags: review?(dkl) → review+
(In reply to Byron Jones ‹:glob› from comment #3)
> the dino head has been retired.
> see the bottom of
> http://www.mozilla.org/en-US/styleguide/identity/mozilla/branding/

NEVER!

> perhaps the mm graphic would be better:
> http://www.gravatar.com/avatar/?f=y&d=mm&s=32

Sure. The default gravatar logo is terrible. :P
(Assignee)

Comment 7

4 years ago
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
added extensions/Gravatar
added extensions/Gravatar/Config.pm
added extensions/Gravatar/Extension.pm
added extensions/Gravatar/template
added extensions/Gravatar/template/en
added extensions/Gravatar/template/en/default
added extensions/Gravatar/template/en/default/hook
added extensions/Gravatar/template/en/default/hook/bug
added extensions/Gravatar/template/en/default/hook/global
added extensions/Gravatar/template/en/default/hook/bug/comments-user-image.html.tmpl
added extensions/Gravatar/template/en/default/hook/bug/show-header-end.html.tmpl
added extensions/Gravatar/template/en/default/hook/global/setting-descs-settings.none.tmpl
modified extensions/InlineHistory/template/en/default/hook/bug/comments-aftercomments.html.tmpl
modified template/en/default/bug/comments.html.tmpl
Committed revision 8938.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.