903971 - [Contacts] Can't import vcard truncates fields encoded as quoted-printable with soft line breaks.

Status: RESOLVED DUPLICATE of bug 904973

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Leo]

1. Title: Can't import vCard truncates fields encoded as quoted-printable with soft line breaks.
2. Precondition:  Save vCard truncates fields encoded as quoted-printable with soft line breaks in SD Card.
3. Tester's Action:  Contacts > Settings > SD card
4. Detailed Symptom (ENG.): Can't import vCard.(Could not import contacts from SD card)
5. Expected:  vCard should be imported.
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train: Reproduced
8. Gaia Revision:   c5e8358d753b8954de7b1a8c3e00944617aeec5e
9. Personal email id: [e-mail]

ex)
BEGIN:VCARD
VERSION:3.0
N;CHARSET=UTF-8:Bar;Foo;;;
FN;CHARSET=UTF-8:Foo Bar
BDAY;CHARSET=UTF-8:1975-05-20
TEL;CHARSET=UTF-8;TYPE=CELL:[phone]
EMAIL;CHARSET=UTF-8;TYPE=HOME:[e-mail]
ADR;WORK;ENCODING=QUOTED-PRINTABLE;CHARSET=UTF-8:;;;;;;123 Winding Way=0D=0A=
  Any Town, CA 12345=0D=0A=
  USA
ORG;CHARSET=UTF-8:;
END:VCARD

Comment 1

[:gerard-majax]

Looking into this one.

Comment 2

[:gerard-majax]

Copy/paste of the proposed vCard to test.vcf, pushed on sdcard, imported successfully on the device.

So I cannot reproduce this on Gaia v1-train @ 849cee8a.

This has been either fixed or your steps to reproduce are incomplete.

Comment 3

[chlee2363]

1) ADR string of the upper contact is wrong decoded.
   Actual:   123 Winding Way =
   Expected: 123 Winding Way Any Town, CA 12345 USA

2) The below contact get a error while importing.
   ('Could not import contacts from SD card')

BEGIN:VCARD
VERSION:3.0
N;CHARSET=UTF-8:Bar;Foo
TEL;HOME;VOICE;CHARSET=UTF-8:[phone]
EMAIL;HOME;CHARSET=UTF-8:[e-mail]
ADR;WORK;ENCODING=QUOTED-PRINTABLE;CHARSET=UTF-8:;;;;;;Franz=C3=
=A4sisch
ORG;CHARSET=UTF-8:Company
END:VCARD

Comment 4

[:gerard-majax]

Thanks, I'm on this !

Comment 5

[:gerard-majax]

> 2) The below contact get a error while importing.
>    ('Could not import contacts from SD card')
> 
> BEGIN:VCARD
> VERSION:3.0
> N;CHARSET=UTF-8:Bar;Foo
> TEL;HOME;VOICE;CHARSET=UTF-8:[phone]
> EMAIL;HOME;CHARSET=UTF-8:[e-mail]
> ADR;WORK;ENCODING=QUOTED-PRINTABLE;CHARSET=UTF-8:;;;;;;Franz=C3=
> =A4sisch
> ORG;CHARSET=UTF-8:Company
> END:VCARD

I do reproduce this too: in unit tests, this VCF produces a timeout.

FYI, for further reference, here is the output of Python's quopri on those two cases:

>>> quopri.decodestring("Franz=C3=\n=A4sisch")
'Franz\xc3\xa4sisch'
>>> quopri.decodestring("23 Winding Way=0D=0A=")
'23 Winding Way\r\n'

Comment 6

[:gerard-majax]

Looks like in the case of your second vCard, it's the email field that makes the code going wild.

Comment 7

[:gerard-majax]

Email and tel field, in fact:

> TEL;HOME;VOICE;CHARSET=UTF-8:[phone]
> EMAIL;HOME;CHARSET=UTF-8:[e-mail]
This produces a timeout.


> TEL;CHARSET=UTF-8:[phone]
> EMAIL;CHARSET=UTF-8:[e-mail]
This produces no timeout.

Comment 8

[Hubert Figuiere [:hub]]

I wonder is that's also not related to bug 905656

Comment 9

[:gerard-majax]

(In reply to Hubert Figuiere [:hub] from comment #8)
> I wonder is that's also not related to bug 905656

Seems very close, although I'm wondering if the current bug might not be splitted into two.

Comment 10

[:gerard-majax]

De-assigning myself since I won't be able to address it this week.

Comment 11

[Preeti Raghunath(:Preeti)]

moving to leo? This bug was leo+ for LG. Since they are done with their testing moving to leo?

Comment 12

[Preeti Raghunath(:Preeti)]

Wayne,

Please check if any of the other carriers need this bug.

Comment 13

[Wayne Chang [:wchang]]

Flagging joe/ivan.

As this was reported by Leo, I would suggest we remove leo+ if they no longer need it and leave other oems as is. But Joe and Ivan can check if they would see this as a concern.

Comment 14

[Ivan Tsay (:ITsay)]

I think this one is the same as the leo+ Bug 904973 which is under tracking for ZTE v1.1 now. I don't have concern on removing leo+ for this one but would like to suggest marking this one as duplication of 904973.

Comment 15

[Preeti Raghunath(:Preeti)]

Minus as per comment 14.