905656 - vcf file freeze on import

Status: RESOLVED DUPLICATE of bug 904973

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Hubert Figuiere [:hub]]

Attachment: address.vcf

Copy the attached vcf onto the sdcard

In contact, select import from sdcard

The import will "hang". A the cancel button will not work.

(the vcf has been generated with a Perl script of my own from a CSV file coming from "FakeNameGenerator")

Comment 1

[Hubert Figuiere [:hub]]

I get this in logcat.

I/Gecko   (  618): 
I/Gecko   (  618): ###!!! [Parent][AsyncChannel] Error: Channel error: cannot send/recv
I/Gecko   (  618): 
E/GeckoConsole(  618): [JavaScript Error: "[Exception... "'Error: no message manager set' when calling method: [nsIObserver::observe]"  nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: no]"]

618 is the pid for the b2g process.

Comment 2

[Hubert Figuiere [:hub]]

The error is more trivial that that.

In "contacts_settings.js" in the onFiles() function, VCFReader is unknown.

Comment 3

[Hubert Figuiere [:hub]]

um. Forget that last comment. This is not the case.

Comment 4

[Hubert Figuiere [:hub]]

I forgot to mention: this is master (1.2) built from source on Inari.

Comment 5

[Hubert Figuiere [:hub]]

Related: bug 903971

Comment 6

[Dietrich Ayala (:dietrich)]

Is VCF import required for 1.2? If so, should this block Koi?

Comment 7

[Hubert Figuiere [:hub]]

(In reply to Dietrich Ayala (:dietrich) from comment #6)
> Is VCF import required for 1.2? If so, should this block Koi?

Related bug is leo+, so I guess it might be.

Comment 8

[:gerard-majax]

I'd bet that this is due to the amount of contacts. I ran into this issue whil debugging bug 903971. After discussing with sergi, he started to rewrite the vCard importing using a stream approch. I've just successfully tested it on a dataset of 6000 contacts. It's still early work, but at least the import went through instead of blocking.

So there is good chances that this bug will get fixed with this new streaming import.

Comment 9

[Hubert Figuiere [:hub]]

What's the bug for the new streaming import?

Comment 10

[:gerard-majax]

You should ask sergi, I'm not sure there's one yet.

Comment 11

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Hi,

Progress on this can be followed on https://bugzilla.mozilla.org/show_bug.cgi?id=904313.

Hubert, try to see if you have that problem with that branch. It should be stable enough to see if it solves it.

Comment 12

[Hubert Figuiere [:hub]]

I definitely goes further. I get "1/5000" displayed. But then it doesn't move.

Comment 13

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Ok, I am working on it and getting somewhere. The investigation and review of the patch will be happening in https://bugzilla.mozilla.org/show_bug.cgi?id=904973 from now on.

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

Sergi, are you still working on this? thanks

Comment 15

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

This issue is now being handled at https://bugzilla.mozilla.org/show_bug.cgi?id=904973.