90404 - Generate embed-jar.mn, remove cvs version

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Chris McAfee]

Generate embed-jar.mn, remove cvs version of this file.

Comment 1

[Chris McAfee]

over to adam for his checkin of gen_mn.pl

Comment 2

[Adam Lock]

Attachment: Latest version of gen_mn.pl for perusal. Tree is still closed so it will go in tomorrow morning, diffs to makefiles to activate it will follow after that

Comment 3

[Chris McAfee]

Attachment: Here is the diff version for gen_mn.pl

Comment 4

[Adam Lock]

Attachment: Changes to makefiles & embed-jar.mn to use new gen_mn.pl

Comment 5

[Adam Lock]

The patch updates the makefile.win, Makefile.in and embed-jar.mn file to use 
the new gen_mn.pl manifest generator. The sequence is this:

1. embed-jar.mn contains lists of files & directories we would *like* in 
embed.jar.
2. Makefile runs embed-jar.mn through gen_mn.pl to create embed-tmp.mn. This 
is the actual manifest of files, produced from the input, with warnings if 
files or directories don't exist.
3. embed-tmp.mn is fed to the package. Since all the files in embed-tmp.mn 
exist on the machine, the package shouldn't fail on option chrome such as the 
help module, platform specific stuff etc.

I have tested on Win32 & Linux so I'm looking for reviews please.

Comment 6

[Adam Lock]

Can I have a review please, the number of manifest bugs are stacking up!

Comment 7

[Chak Nanga]

r=chak [for the windows part]
I tested this on Windows and works fine.

Comment 8

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 9

[Chris McAfee]

r=mcafee for 7/12 patch.

Comment 10

[Adam Lock]

Fix is checked in

Comment 11

[Christof Meerwald]

it seems that the patch broke makefile.win: line 29 generates embed.mn, but
lines 30 and 31 try to use embed-tmp.mn

line 29 of makefile.win should be changed to:

$(PERL) gen_mn.pl -manifest embed-jar.mn -mozpath $(DEPTH) -chrome
$(DIST)/bin/chrome > embed-tmp.mn

Comment 12

[Chris McAfee]

reopening to resolve windows issue

Comment 13

[Adam Lock]

Attachment: Patch fixes makefile.win's chrome format != jar execution path. r/sr please

Comment 14

[Adam Lock]

Fix for bustage checked in

Comment 15

[Michael Dunn]

Clean up verification of dated code change bus