904111 - [MP] Defect - Flyout errors interfering with update button functionality

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P2)

Comment 1

[Jim Mathies [:jimm]]

TypeError: FlyoutPanelsUI.AboutFlyout is undefined
chrome://browser/content/browser.xul
1

Comment 2

[Jim Mathies [:jimm]]

Looks like it should be AboutFlyoutPanel. (bug 897830)

Comment 3

[Jim Mathies [:jimm]]

Attachment: fix

Comment 4

[Brian R. Bondy [:bbondy]]

Comment on attachment 789071 [details] [diff] [review]
fix

Review of attachment 789071 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/browser-element/BrowserElementPanning.js
@@ -463,5 @@
> -      return metroUtils && metroUtils.immersive;
> -    } catch (e) {}
> -    return false;
> -  },
> -

qref'ed this out of the wrong patch

Comment 5

[Jim Mathies [:jimm]]

ahh poop.

Comment 6

[Jim Mathies [:jimm]]

Attachment: fix

Comment 7

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 789071 [details] [diff] [review]
fix

Review of attachment 789071 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you fix the issue brian mentioned. Also double-check the indentation on that line in browser.xul. Splinter is showing the line as having no indentation at all.

::: browser/metro/base/content/browser.xul
@@ +383,5 @@
>  #ifdef MOZ_UPDATER
>          <deck id="updateDeck" orient="vertical">
>            <hbox id="updateButtonBox" align="center">
>              <button id="updateButton" align="start"
> +                    oncommand="FlyoutPanelsUI.AboutFlyoutPanel.appUpdater.buttonOnCommand();"/>

nit: What happened to the indentation here? Is splinter just showing this weirdly?

Comment 8

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 789071 [details] [diff] [review]
fix

Oops, reviewed obsolete patch

Comment 9

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 789083 [details] [diff] [review]
fix

Review of attachment 789083 [details] [diff] [review]:
-----------------------------------------------------------------

Just double-check the indentation plz

Comment 10

[Jim Mathies [:jimm]]

Attachment: export

Comment 11

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/fx-team/rev/d62d628d5308

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/d62d628d5308

Comment 13

[Manuela Muntean [Away]]

Could anyone please give any guidelines that can help the QA in verifying this issue? Thanks!

Comment 14

[Jim Mathies [:jimm]]

(In reply to Manuela Muntean [:Manuela] [QA] from comment #13)
> Could anyone please give any guidelines that can help the QA in verifying
> this issue? Thanks!

If you can test updates, the ability to click the restart button would verify this.

Comment 15

[Manuela Muntean [Away]]

> If you can test updates, the ability to click the restart button would
> verify this.

Verified as fixed, with the latest Nightly (build ID: 20130915030208), for iteration #14, following the above indication. The updates and the restart button both work.