Closed Bug 904111 Opened 6 years ago Closed 6 years ago

[MP] Defect - Flyout errors interfering with update button functionality

Categories

(Firefox for Metro Graveyard :: Browser, defect, P2)

x86_64
Windows 8.1
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 26

People

(Reporter: jimm, Assigned: jimm)

References

Details

(Whiteboard: [preview] feature=defect c=tbd u=tbd p=1)

Attachments

(2 files, 1 obsolete file)

No description provided.
Summary: Flyout errors interfering with update button functionlaity → Flyout errors interfering with update button functionality
TypeError: FlyoutPanelsUI.AboutFlyout is undefined
chrome://browser/content/browser.xul
1
Summary: Flyout errors interfering with update button functionality → [MP] Defect - Flyout errors interfering with update button functionality
Whiteboard: [preview] → [preview] feature=defect c=tbd u=tbd p=0
Looks like it should be AboutFlyoutPanel. (bug 897830)
No longer blocks: metrov1defect&change
Summary: [MP] Defect - Flyout errors interfering with update button functionality → Flyout errors interfering with update button functionality
Whiteboard: [preview] feature=defect c=tbd u=tbd p=0 → [preview]
Assignee: nobody → jmathies
Blocks: metrov1it13
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Summary: Flyout errors interfering with update button functionality → [MP] Defect - Flyout errors interfering with update button functionality
Whiteboard: [preview] → [preview] feature=defect c=tbd u=tbd p=0
Whiteboard: [preview] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=1
Attached patch fix (obsolete) — Splinter Review
Attachment #789071 - Flags: review?(tabraldes)
Comment on attachment 789071 [details] [diff] [review]
fix

Review of attachment 789071 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/browser-element/BrowserElementPanning.js
@@ -463,5 @@
> -      return metroUtils && metroUtils.immersive;
> -    } catch (e) {}
> -    return false;
> -  },
> -

qref'ed this out of the wrong patch
ahh poop.
Attached patch fixSplinter Review
Attachment #789071 - Attachment is obsolete: true
Attachment #789071 - Flags: review?(tabraldes)
Attachment #789083 - Flags: review?(tabraldes)
Comment on attachment 789071 [details] [diff] [review]
fix

Review of attachment 789071 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you fix the issue brian mentioned. Also double-check the indentation on that line in browser.xul. Splinter is showing the line as having no indentation at all.

::: browser/metro/base/content/browser.xul
@@ +383,5 @@
>  #ifdef MOZ_UPDATER
>          <deck id="updateDeck" orient="vertical">
>            <hbox id="updateButtonBox" align="center">
>              <button id="updateButton" align="start"
> +                    oncommand="FlyoutPanelsUI.AboutFlyoutPanel.appUpdater.buttonOnCommand();"/>

nit: What happened to the indentation here? Is splinter just showing this weirdly?
Attachment #789071 - Attachment is obsolete: false
Comment on attachment 789071 [details] [diff] [review]
fix

Oops, reviewed obsolete patch
Attachment #789071 - Attachment is obsolete: true
Comment on attachment 789083 [details] [diff] [review]
fix

Review of attachment 789083 [details] [diff] [review]:
-----------------------------------------------------------------

Just double-check the indentation plz
Attachment #789083 - Flags: review?(tabraldes) → review+
Attached patch exportSplinter Review
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d62d628d5308
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Could anyone please give any guidelines that can help the QA in verifying this issue? Thanks!
Flags: needinfo?
Flags: needinfo? → needinfo?(jmathies)
(In reply to Manuela Muntean [:Manuela] [QA] from comment #13)
> Could anyone please give any guidelines that can help the QA in verifying
> this issue? Thanks!

If you can test updates, the ability to click the restart button would verify this.
Flags: needinfo?(jmathies)
> If you can test updates, the ability to click the restart button would
> verify this.

Verified as fixed, with the latest Nightly (build ID: 20130915030208), for iteration #14, following the above indication. The updates and the restart button both work.
Status: RESOLVED → VERIFIED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.