Closed Bug 904620 Opened 6 years ago Closed 6 years ago

WebGL hangs in SurfaceStream_TripleBuffer_Async::WaitForCompositor

Categories

(Core :: Canvas: WebGL, defect, major)

x86
macOS
defect
Not set
major

Tracking

()

VERIFIED FIXED
mozilla26
Tracking Status
firefox24 --- unaffected
firefox25 + verified
firefox26 + verified

People

(Reporter: BenWa, Assigned: mattwoodrow)

References

()

Details

(Keywords: regression)

Attachments

(2 files)

STR:
1) Open: http://glecollinet.github.io/webgl-demo/

I get a hang with nightly on 10.8
Same 10.9, bisecting...
I'm having trouble to compile on 10.9, but here is the window I already have by the ftp:
 - ok:  ff0a372e3170 (2013-07-15-03-02-02)
 - ok:  c2b375f3a909 (2013-07-31-03-02-03)
 - ok:  76a944fa6b25 (2013-08-02-03-02-04)
 - bad: d0edf8086809 (2013-08-03-03-02-05)
 - bad: 0a63cd911b4f (2013-08-04-03-02-07)
 - bad: 1fb5d14e8348 (2013-08-07-03-02-16)
This appeared for me for the first time in Firefox Nightly 8-3-2013.

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-03-03-02-05-mozilla-central/

I'm running on a Mac 10.8.

This is blocking partner contract work for Firefox OS.
I took a sample with Activity Monitor on Mac OS X to add more information about the hang.
This does not appear to affect windows or linux.
Duplicate of this bug: 904611
Odds are high that this is:
904611
Summary: WebGL bounce demo hangs Firefox → WebGL hangs in SurfaceStream_TripleBuffer_Async::WaitForCompositor
I suspect bug 900188. Mattwoodrow?
It looks like this patch makes it so we don't always SwapConsumer anymore, which will hang SwapProducer if SP is called twice before SC is called.
Flags: needinfo?(matt.woodrow)
Looks like we just cancel the transaction if it's empty, and never schedule a composite.

We could add an explicit 'composite using the existing surface' message or type, but I don't think it's worth it.
Attachment #790987 - Flags: review?(ncameron)
Flags: needinfo?(matt.woodrow)
Attachment #790987 - Flags: review?(ncameron) → review+
See Also: → 905041
Assignee: nobody → matt.woodrow
https://hg.mozilla.org/mozilla-central/rev/de84e2d0c9c5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Depends on: 911680
btw, this bug was a regression from bug 900188 in Nightly 25 build 2013-08-03.
Blocks: 900188
Ready for uplift Matt?
Flags: needinfo?(matt.woodrow)
Comment on attachment 790987 [details] [diff] [review]
Always send the SurfaceStream across

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 900188
User impact if declined: Hangs with WebGL content
Testing completed (on m-c, etc.): Been on m-c for weeks.
Risk to taking this patch (and alternatives if risky): Very low risk, just disables a (broken) optimization.
String or IDL/UUID changes made by this patch: None
Attachment #790987 - Flags: approval-mozilla-aurora?
Comment on attachment 790987 [details] [diff] [review]
Always send the SurfaceStream across

[Triage Comment]
itym beta nomination since this is already marked fixed on 26 (Aurora).
Attachment #790987 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
Flags: needinfo?(matt.woodrow)
I think we need bug 912173 to be uplifted with it.
Flags: needinfo?(matt.woodrow)
Duplicate of this bug: 913056
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0) Gecko/20100101 Firefox/25.0
Build ID: 20130926170421

The situation looks pretty bad on Mac OS X and Firefox 25 beta 3:
https://moztrap.mozilla.org/results/cases/?filter-run=2331

Will this get uplifted to Firefox 25?
(In reply to Simona B [QA] from comment #20)
> Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0) Gecko/20100101
> Firefox/25.0
> Build ID: 20130926170421
> 
> The situation looks pretty bad on Mac OS X and Firefox 25 beta 3:
> https://moztrap.mozilla.org/results/cases/?filter-run=2331
> 
> Will this get uplifted to Firefox 25?

Still waiting on bug 912173 to be uplifted which was just requested yesterday.
(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #21)
> (In reply to Simona B [QA] from comment #20)
> > Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0) Gecko/20100101
> > Firefox/25.0
> > Build ID: 20130926170421
> > 
> > The situation looks pretty bad on Mac OS X and Firefox 25 beta 3:
> > https://moztrap.mozilla.org/results/cases/?filter-run=2331
> > 
> > Will this get uplifted to Firefox 25?
> 
> Still waiting on bug 912173 to be uplifted which was just requested
> yesterday.

That patch is now approved for Beta 25.
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0) Gecko/20100101 Firefox/25.0

Looks good now on Firefox 25 beta 4 (buildID: 20131001024718) and latest Aurora (buildID: 20131002004002) after running the tests from the testrun wrote in comment 20.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.