905096 - Build script modularization

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

for now we use xpcshell to execute javascript in GAIA_DIR/build/, we should use module pattern for those scripts to help developer can reuse those scripts to customize build process.

I would like to use commonjs pattern to encapsulate each script in GAIA_DIR into a module. to do that, I need to use commonjs/toolkit/loader.js to define require to solve dependency issue.

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

WIP: https://github.com/yurenju/gaia/commit/2acfd1f4e2eada107945503d0feef15fba3d9e63

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: wip.patch

today WIP, now we can use sdk/io/fs! :D

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Hi Alex, Could you give some feedback for xpcshell-commonjs.js in attachment 790732 [details] [diff] [review]? it works but it would be great if you can take a look to it :)

you also can read it on github: https://github.com/yurenju/gaia/blob/82a9e37c556d9be5da1af27f9ecbfe6bb0869c1b/build/xpcshell-commonjs.js

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: wip2.patch

now we can |make reset-gaia| with xpcshell modules! wooooow!

I'm working on cleaning code and test build/*.js one by one to check everything is okay.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: wip2.patch

I forgot adding files when commit, update to new patch.

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: github PR: https://github.com/mozilla-b2g/gaia/pull/11693

This pull request is ready to review,I tested each script on xpcshell and everthing looks good. Since changes of build system is easy to get failed on TBPL, I would like to get two r+ to land it.

Tim and Alex, could you review this PR? thanks!

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 793928 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/11693

Splendid! You should feedback? :lightsofapollo too IMHO.

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 793928 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/11693

James, could you give some feedback for this? thanks!

Comment 9

[James Lal [:lightsofapollo]]

Comment on attachment 793928 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/11693

Looks good! I did some basic sanity testing too and everything in my daily workflow works well.

Comment 10

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 793928 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/11693

since Alex looks very busy, I'll land this commit first only with r=timdream after verified this commit on windows.

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

pull request was updated for Windows.

Comment 12

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

merged. 
https://github.com/mozilla-b2g/gaia/commit/4abecf9578f5a6f58ea1c69c19b53a8f45bc650a