905495 - unit test infrastructure for gaia build system

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

we shoud have unit test infrasture for gaia build system to help us have a reliable and testable build system.

we plan to support node.js and firefox extension for our build system, so this infrasture should have compatibility to run both on those two javascript environments.

Using mocha might be a good idea because it can run on node.js and browser with different configuration.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

WIP,
https://github.com/cctuan/gaia/commit/2753d5de35674d6f62dd0746471c578ab6327967

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

This patch has implemented the first step of build test.
We'll implement more tests later.

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8347858 [details]
PR to master

1. please use tdd style for unit tests
2. now we have conflict, please rebase and set me review flag again.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8347858 [details]
PR to master

Changed to tdd and rebased.
Thanks.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8347858 [details]
PR to master

looks good to me, r=yurenju if nits is addressed which I mentioned on github.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks Yuren!
https://github.com/mozilla-b2g/gaia/commit/45683b75b25449f44780a2a6b4f6fdb89887e047
We'll open several bugs to add unit tests for build scripts.