905116 - (homescreen-window) [Window Management] Move homescreen life cycle management out of window manager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

Homescreen app's life cycle is irrelevant to manage other windows.
This bug's target is to move nearly all homescreen specific code out of window manager, just like FTU Launcher, and then the following step would be to implement HomescreenWindow(inherited from revised appWindow class).

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Homescreen Launcher WIP
https://github.com/alivedise/gaia/compare/bugzilla;905116;homescreen-launcher?expand=1

Not really working now. Another -100 lines work of window manager.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

WIP today
https://github.com/alivedise/gaia/commit/081cd6081050bab3a89276a5dd9447ba3159647d

* Add homescreenWindow.
* Use render and view in homescreenWindow instead of appendFrame in WindowManager.
* Move sth. out of WM to BS

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

WIP today
https://github.com/alivedise/gaia/commit/940d6705fe1a2d42fdb61e1f786e0d826ac54b48

Still have some coding style issues but it works now.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

WIP today
Try to move more homescreen specific logic from WM into HW.
Implement simple transition state machine control in HW.
*NOT TESTED YET*

https://github.com/alivedise/gaia/commit/2f12fcabaed7e6460fdc3fc92374c05e8dcf4614

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

WIP today
https://github.com/alivedise/gaia/commit/1573a41a39c122aa71c0d76b6ff4a1ec7a9dd1d3
* Combine HomescreenLauncher into HomescreenWindow class.

Nearly done!

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

WIP today
https://github.com/alivedise/gaia/commit/61796de1947c05d9a54d9befe21898a8a74d57e8

Test done
Known issue: Closing Window has some latency.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/11854

Patch v1:
* Introduce HomescreenWindow(HW when mentioned below) class inherited AppWindow
* Remove as most as possible Homescreen specific value from WindowManager(WM when mentioned below)
* Move something into Bootstrap(BS when mentioned below) from WM

Todo in next followup:
* Clean BS, too.
* Clean HW constructor dirties and use the same mechanism into AppWindow.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 797700 [details]
https://github.com/mozilla-b2g/gaia/pull/11854

Looks good except for the module + prototype pattern.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 797700 [details]
https://github.com/mozilla-b2g/gaia/pull/11854

Should be an f+ instead of an r+.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 797700 [details]
https://github.com/mozilla-b2g/gaia/pull/11854

Add part 2: HomescreenLauncher.
I'll squash into one commits after getting r+.

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

Happy conflicting...

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

master
https://github.com/mozilla-b2g/gaia/commit/3384ddd62af4d16d02180a0d51629ec637f483e1


TrustedUI issues would be addressed in https://bugzilla.mozilla.org/show_bug.cgi?id=911880
Origin issues would be addressed in incoming followup.


\O/ WindowManager ~= 1700L now.

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Backouted
https://github.com/mozilla-b2g/gaia/commit/1c704fa7e4925568131e033bfcbde04b83d653ac

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

I am working on adding unit tests. Come back soon.

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

WIP
https://github.com/mozilla-b2g/gaia/pull/11914

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Alive Kuo [:alive] from comment #15)
> WIP
> https://github.com/mozilla-b2g/gaia/pull/11914
shall be https://github.com/mozilla-b2g/gaia/pull/12086/files

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/pull/12086/files

I found that warm boot of app transition takes more time now.
It's the gap between visibility->true to next paint event. I still don't know why now, will track in another bug.
Short term solution is cancel the next paint handler right away.

Comment 18

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/12086

Part 2: Add unit tests and quick fix app opening delay.

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

Something weird found: quickly tapping HW home button during app is opening does show empty wallpaper. Investigating.

Comment 20

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 804375 [details]
https://github.com/mozilla-b2g/gaia/pull/12086

Canceling

Comment 21

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Alive Kuo [:alive] from comment #19)
> Something weird found: quickly tapping HW home button during app is opening
> does show empty wallpaper. Investigating.

Fixed, the fix is pretty simple: just modify the policy of transition states. Unit test fixed as well.

Comment 22

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 804375 [details]
https://github.com/mozilla-b2g/gaia/pull/12086

https://github.com/alivedise/gaia/commit/54573c75f9cf0d65da655ffa113db6e4c4fa1bac

Comment 23

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 804375 [details]
https://github.com/mozilla-b2g/gaia/pull/12086

https://github.com/alivedise/gaia/commit/ba53dab8ca241c84995339d353e641b549331d98

Revised replace homescreen pattern

Comment 24

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 804375 [details]
https://github.com/mozilla-b2g/gaia/pull/12086

Thank you!

Comment 25

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/3408cc3f6b190c8cd31832fbb8cd2ae571041f29

Comment 26

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Hmm... This appears to break the trusted ui.  I've opened Bug 919833 to submit a patch.

Comment 27

[James Lal [:lightsofapollo]]

Backed out here: https://github.com/mozilla-b2g/gaia/commit/e9effbe9997713eaa35b21c0c0cf47bff1e97440

This is a sad case where this was red on CI https://travis-ci.org/mozilla-b2g/gaia/jobs/11681343#L1335 and was merged anyway... This breaks persona please make sure CI is 100% green prior to landing this or any other future work.

Comment 28

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/12414

Part 3: Fix TrustedUI + BrowserFrame + Test

Comment 29

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 809647 [details]
https://github.com/mozilla-b2g/gaia/pull/12414

Sorry for not paying attention to the test failure.

Comment 30

[(inactive after 6/18) Alive Kuo [:alive]]

Travis is green now, I'm going to merge again and cross finger.
https://travis-ci.org/mozilla-b2g/gaia/builds/11763620

Comment 31

[(inactive after 6/18) Alive Kuo [:alive]]

Squashing commits into one..

Comment 32

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/afb7f95a2696a415e28dc5461022072d4270596c
https://travis-ci.org/mozilla-b2g/gaia/builds/11763620