Closed
Bug 905116
(homescreen-window)
Opened 12 years ago
Closed 12 years ago
[Window Management] Move homescreen life cycle management out of window manager
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alive, Assigned: alive)
References
Details
Attachments
(3 files)
Homescreen app's life cycle is irrelevant to manage other windows.
This bug's target is to move nearly all homescreen specific code out of window manager, just like FTU Launcher, and then the following step would be to implement HomescreenWindow(inherited from revised appWindow class).
Assignee | ||
Comment 1•12 years ago
|
||
Homescreen Launcher WIP
https://github.com/alivedise/gaia/compare/bugzilla;905116;homescreen-launcher?expand=1
Not really working now. Another -100 lines work of window manager.
Assignee | ||
Comment 2•12 years ago
|
||
WIP today
https://github.com/alivedise/gaia/commit/081cd6081050bab3a89276a5dd9447ba3159647d
* Add homescreenWindow.
* Use render and view in homescreenWindow instead of appendFrame in WindowManager.
* Move sth. out of WM to BS
Assignee | ||
Comment 3•12 years ago
|
||
WIP today
https://github.com/alivedise/gaia/commit/940d6705fe1a2d42fdb61e1f786e0d826ac54b48
Still have some coding style issues but it works now.
Assignee | ||
Comment 4•12 years ago
|
||
WIP today
Try to move more homescreen specific logic from WM into HW.
Implement simple transition state machine control in HW.
*NOT TESTED YET*
https://github.com/alivedise/gaia/commit/2f12fcabaed7e6460fdc3fc92374c05e8dcf4614
Assignee | ||
Comment 5•12 years ago
|
||
WIP today
https://github.com/alivedise/gaia/commit/1573a41a39c122aa71c0d76b6ff4a1ec7a9dd1d3
* Combine HomescreenLauncher into HomescreenWindow class.
Nearly done!
Assignee | ||
Comment 6•12 years ago
|
||
WIP today
https://github.com/alivedise/gaia/commit/61796de1947c05d9a54d9befe21898a8a74d57e8
Test done
Known issue: Closing Window has some latency.
Assignee | ||
Comment 7•12 years ago
|
||
Patch v1:
* Introduce HomescreenWindow(HW when mentioned below) class inherited AppWindow
* Remove as most as possible Homescreen specific value from WindowManager(WM when mentioned below)
* Move something into Bootstrap(BS when mentioned below) from WM
Todo in next followup:
* Clean BS, too.
* Clean HW constructor dirties and use the same mechanism into AppWindow.
Attachment #797700 -
Flags: review?(timdream)
Comment 8•12 years ago
|
||
Comment on attachment 797700 [details]
https://github.com/mozilla-b2g/gaia/pull/11854
Looks good except for the module + prototype pattern.
Attachment #797700 -
Flags: review?(timdream) → review+
Comment 9•12 years ago
|
||
Comment on attachment 797700 [details]
https://github.com/mozilla-b2g/gaia/pull/11854
Should be an f+ instead of an r+.
Attachment #797700 -
Flags: review+ → feedback+
Assignee | ||
Comment 10•12 years ago
|
||
Comment on attachment 797700 [details]
https://github.com/mozilla-b2g/gaia/pull/11854
Add part 2: HomescreenLauncher.
I'll squash into one commits after getting r+.
Attachment #797700 -
Flags: review?(timdream)
Updated•12 years ago
|
Attachment #797700 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 11•12 years ago
|
||
Happy conflicting...
Assignee | ||
Comment 12•12 years ago
|
||
master
https://github.com/mozilla-b2g/gaia/commit/3384ddd62af4d16d02180a0d51629ec637f483e1
TrustedUI issues would be addressed in https://bugzilla.mozilla.org/show_bug.cgi?id=911880
Origin issues would be addressed in incoming followup.
\O/ WindowManager ~= 1700L now.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 13•12 years ago
|
||
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 14•12 years ago
|
||
I am working on adding unit tests. Come back soon.
Assignee | ||
Comment 15•12 years ago
|
||
Assignee | ||
Comment 16•12 years ago
|
||
(In reply to Alive Kuo [:alive] from comment #15)
> WIP
> https://github.com/mozilla-b2g/gaia/pull/11914
shall be https://github.com/mozilla-b2g/gaia/pull/12086/files
Assignee | ||
Comment 17•12 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/12086/files
I found that warm boot of app transition takes more time now.
It's the gap between visibility->true to next paint event. I still don't know why now, will track in another bug.
Short term solution is cancel the next paint handler right away.
Assignee | ||
Comment 18•12 years ago
|
||
Part 2: Add unit tests and quick fix app opening delay.
Attachment #804375 -
Flags: review?(timdream)
Assignee | ||
Comment 19•12 years ago
|
||
Something weird found: quickly tapping HW home button during app is opening does show empty wallpaper. Investigating.
Assignee | ||
Comment 20•12 years ago
|
||
Comment on attachment 804375 [details]
https://github.com/mozilla-b2g/gaia/pull/12086
Canceling
Attachment #804375 -
Flags: review?(timdream)
Assignee | ||
Comment 21•12 years ago
|
||
(In reply to Alive Kuo [:alive] from comment #19)
> Something weird found: quickly tapping HW home button during app is opening
> does show empty wallpaper. Investigating.
Fixed, the fix is pretty simple: just modify the policy of transition states. Unit test fixed as well.
Assignee | ||
Comment 22•12 years ago
|
||
Comment on attachment 804375 [details]
https://github.com/mozilla-b2g/gaia/pull/12086
https://github.com/alivedise/gaia/commit/54573c75f9cf0d65da655ffa113db6e4c4fa1bac
Attachment #804375 -
Flags: review?(timdream)
Updated•12 years ago
|
Attachment #804375 -
Flags: review?(timdream)
Assignee | ||
Comment 23•12 years ago
|
||
Comment on attachment 804375 [details]
https://github.com/mozilla-b2g/gaia/pull/12086
https://github.com/alivedise/gaia/commit/ba53dab8ca241c84995339d353e641b549331d98
Revised replace homescreen pattern
Attachment #804375 -
Flags: review?(timdream)
Comment 24•12 years ago
|
||
Comment on attachment 804375 [details]
https://github.com/mozilla-b2g/gaia/pull/12086
Thank you!
Attachment #804375 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 25•12 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Comment 26•12 years ago
|
||
Hmm... This appears to break the trusted ui. I've opened Bug 919833 to submit a patch.
Comment 27•12 years ago
|
||
Backed out here: https://github.com/mozilla-b2g/gaia/commit/e9effbe9997713eaa35b21c0c0cf47bff1e97440
This is a sad case where this was red on CI https://travis-ci.org/mozilla-b2g/gaia/jobs/11681343#L1335 and was merged anyway... This breaks persona please make sure CI is 100% green prior to landing this or any other future work.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 28•12 years ago
|
||
Part 3: Fix TrustedUI + BrowserFrame + Test
Attachment #809647 -
Flags: review?(timdream)
Comment 29•12 years ago
|
||
Comment on attachment 809647 [details]
https://github.com/mozilla-b2g/gaia/pull/12414
Sorry for not paying attention to the test failure.
Attachment #809647 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 30•12 years ago
|
||
Travis is green now, I'm going to merge again and cross finger.
https://travis-ci.org/mozilla-b2g/gaia/builds/11763620
Assignee | ||
Comment 31•12 years ago
|
||
Squashing commits into one..
Assignee | ||
Comment 32•12 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/afb7f95a2696a415e28dc5461022072d4270596c
https://travis-ci.org/mozilla-b2g/gaia/builds/11763620
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
Blocks: task-manager
Assignee | ||
Updated•12 years ago
|
No longer blocks: task-manager
Assignee | ||
Updated•12 years ago
|
Alias: homescreen-window
You need to log in
before you can comment on or make changes to this bug.
Description
•