919833 - Trusted UI broken: HomescreenLauncher.toggle is not a function

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

STR

- open UI Tests app
- choose navigator.mozId tests
- In the test page, choose 'request'

Expected: Persona sign-in dialog appears

Actual: Following error:

E/GeckoConsole(  442): [JavaScript Error: "HomescreenWindow.toggle is not a function" {file: "app://system.gaiamobile.org/js/trusted_ui.js" line: 149}]

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Sorry, that log should read HomescreenLauncher, not HomescreenWindow.

I think there's an error in Bug 905116.  Looks like a quick fix.

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: 919833-PR.html

Hi, Alive.  Do you mind taking a look?  Did I fix this correctly?  Thanks, j

Comment 3

[Jason Smith [:jsmith]]

Isn't this a dupe of bug 919629?

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 808924 [details]
919833-PR.html

Thanks for fixing my bug!!!!!

Comment 5

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Alive Kuo [:alive] from comment #4)
> Comment on attachment 808924 [details]
> 919833-PR.html
> 
> Thanks for fixing my bug!!!!!

No worries, thanks for the speedy review!

Comment 6

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Jason Smith [:jsmith] from comment #3)
> Isn't this a dupe of bug 919629?

You're right, it looks like it is.

Since Alive's just reviewed this here, I think I should go ahead and merge this into gaia and not move the PR at this point, nu?

Comment 8

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Hi, John, I think the gaia tree is closed at the moment.  What's the right thing to do to commit this patch?  Tag with checkin-needed?  Something else?

Comment 9

[Jason Smith [:jsmith]]

Fixed by backout on bug 905116.

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

According to comment 9, it looks like we're done here.  Is that correct?

Comment 11

[Jason Smith [:jsmith]]

(In reply to John Ford [:jhford] -- please use 'needinfo?' instead of a CC from comment #10)
> According to comment 9, it looks like we're done here.  Is that correct?

Yup.