Closed Bug 905155 Opened 11 years ago Closed 11 years ago

Remove the XPFE autocomplete component

Categories

(MailNews Core :: Build Config, defect)

Product:
MailNews Core
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 26.0

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(2 files)

Stop linking XPFE autocomplete into libxul
2.08 KB, patch
standard8
: review+
Details | Diff | Splinter Review
Stop building the component
22.25 KB, patch
standard8
: review+
Details | Diff | Splinter Review 
LDAP autocomplete was the last use of the XPFE autocomplete component.
Please don't blindly delete -- Graveyard is a better place.
(In reply to Justin Wood (:Callek) from comment #1)
> Please don't blindly delete -- Graveyard is a better place.

err misread this as a bmo admin bug, not mailnews core. Ignore me
Seems that bug 789787 accidentally duplicated a block of code.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #790206 - Flags: review?(mbanner)
This just leaves the jar.mn and resources.
Attachment #790208 - Flags: review?(mbanner)
Comment on attachment 790206 [details] [diff] [review]
Stop linking XPFE autocomplete into libxul

Yay!
Attachment #790206 - Flags: review?(mbanner) → review+
Attachment #790208 - Flags: review?(mbanner) → review+
https://hg.mozilla.org/mozilla-central/rev/a5c573748a95
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
Not sure this is related, but starting a compose window prints ### ERROR - unable to create search "ldap". which is here http://mxr.mozilla.org/comm-central/source/mozilla/xpfe/components/autocomplete/resources/content/autocomplete.xml#254

... so i suppose we're still using the xpfe autocomplete. Do we just need to remove the AUTOCOMPLETE_OLD_STYLE defines here? http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/xul.css#749
(I don't get the error with local non-packaged builds so i though it's easer to ask.)
(In reply to Magnus Melin from comment #8)
> (I don't get the error with local non-packaged builds

Probably because we're not packaging the component. Oops.
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/9dfd51ec3a5b
Stop building the XPFE autocomplete component r=Standard8
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: