905162 - Misc empty view tweaks

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Lucas Rocha (:lucasr)]

Just some stuff I found while fixing bug 904689.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: (1/3) Fetch empty view from fragment's view instead of activity

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: (2/3) Reset all MostRecentPage views in onDestroyView

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: (3/3) Hide title when showing empty views in MostRecentPage and LastTabsPage

Comment 4

[Chenxia Liu [:liuche]]

Comment on attachment 790215 [details] [diff] [review]
(1/3) Fetch empty view from fragment's view instead of activity

Review of attachment 790215 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good; I'll also be sure to do this for the reading list patch.

Comment 5

[Chenxia Liu [:liuche]]

Attachment: (4/4) Use final for ViewStubs

Can you fold this one into this bug too? I thought I fixed this but just saw it wasn't.

Comment 6

[Lucas Rocha (:lucasr)]

Comment on attachment 790328 [details] [diff] [review]
(4/4) Use final for ViewStubs

Review of attachment 790328 [details] [diff] [review]:
-----------------------------------------------------------------

Good.

Comment 7

[Lucas Rocha (:lucasr)]

Pushed:
http://hg.mozilla.org/projects/fig/rev/be075a38db6e
http://hg.mozilla.org/projects/fig/rev/5c6ab32efd88
http://hg.mozilla.org/projects/fig/rev/e04775b29f63
http://hg.mozilla.org/projects/fig/rev/27a6e8a793a3

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/be075a38db6e
https://hg.mozilla.org/mozilla-central/rev/5c6ab32efd88
https://hg.mozilla.org/mozilla-central/rev/e04775b29f63
https://hg.mozilla.org/mozilla-central/rev/27a6e8a793a3