Intermittent TEST-UNEXPECTED-FAIL | tests/test-panel.test Document Reload | Timed out

RESOLVED FIXED

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: KWierso, Assigned: erikvold)

Tracking

({intermittent-failure})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
TEST-UNEXPECTED-FAIL | tests/test-panel.test Document Reload | Timed out

TEST-INFO | Traceback (most recent call last):

  File "resource://extensions.modules.c157a209-64f3-4a02-b2ce-c955a6918abb-at-jetpack.commonjs.path/sdk/timers.js", line 40, in notify

    callback.apply(null, args);

  File "resource://extensions.modules.c157a209-64f3-4a02-b2ce-c955a6918abb-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 424, in tiredOfWaiting

    self.console.testMessage(false, false, self.test.name, "Timed out");

  File "resource://extensions.modules.c157a209-64f3-4a02-b2ce-c955a6918abb-at-jetpack.commonjs.path/sdk/test/harness.js", line 525, in testMessage

    this.trace();

Happened twice on this push to the Jetpack tree, but hasn't happened since: https://tbpl.mozilla.org/?tree=Jetpack&rev=0c760b1b37ca
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Reporter)

Updated

5 years ago
Priority: -- → P1
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Assignee: nobody → evold
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Created attachment 791148 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1176

Pointer to Github pull-request
Attachment #791148 - Flags: review?(zer0)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment on attachment 791148 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1176

With the comment in the PR addressed.
Attachment #791148 - Flags: review?(zer0) → review+

Comment 47

5 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/147368ca25577ac19c15e1a29c7c8f321f713334
Bug 905338 - Intermittent TEST-UNEXPECTED-FAIL | tests/test-panel.test Document Reload | Timed out
Bug 846165 - Intermittent tests/test-panel.test Document Reload | First document had a content script - true == false

Removing race condition from tests/test-panel.test Document Reload

https://github.com/mozilla/addon-sdk/commit/017ece6998e67e32f6186a727d0ad33b7aa4fc9d
Merge pull request #1176 from erikvold/905338

Bug 905338 - Intermittent TEST-UNEXPECTED-FAIL | tests/test-panel.test Document Reload | Timed out r=@ZER0
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Unfortunately it seems it didn't help to fix the issue. :(
(In reply to Matteo Ferretti [:matteo] [:zer0] from comment #54)
> Unfortunately it seems it didn't help to fix the issue. :(

It seems to have worked to me..
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #55)
> (In reply to Matteo Ferretti [:matteo] [:zer0] from comment #54)
> > Unfortunately it seems it didn't help to fix the issue. :(
> 
> It seems to have worked to me..

Oh right: probably m-c is not synched yet with our master; that's why we have those comment.
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Yeah this change still hasn't made it to mozilla-inbound but the lack of reports from fx-team suggest that this is fixed.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Well this made it to mozilla-inbound on Friday but we still have failures showing up yesterday so I guess this didn't fix it after all :(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 792330 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1203

Pointer to Github pull-request
Attachment #792330 - Flags: review?(dtownsend+bugmail)
Attachment #792330 - Flags: review?(dtownsend+bugmail) → review+

Comment 84

5 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/4fc5bfffd1ac1d2d8bcf58cc6087dbca4c47ce2b
Bug 905338 only redirect the panel location if the message is as expected

https://github.com/mozilla/addon-sdk/commit/cd3ad749b4e6b032b77053b97c8b440a42ebea68
Merge pull request #1203 from erikvold/905338p2

Bug 905338 only redirect the panel location if the message is as expected r=@Mossop
(Reporter)

Comment 85

5 years ago
I'm going to call this fixed. Reopen if I'm wrong.
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.