905621 - Stylize the bad url error page

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Theme, defect, P2)

Description

[Jim Mathies [:jimm]]

Attachment: Screenshot (66).png

This page is fairly common, and totally clashes with the metro theme. Shouldn't be too hard to fix it up if we have a new comp.

Comment 1

[Jim Mathies [:jimm]]

Yuan, do you have time for this? If not, we can kick it to another release.

Comment 2

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

(In reply to Jim Mathies [:jimm] from comment #1)
> Yuan, do you have time for this? If not, we can kick it to another release.

I think that should be fairly easy.

Comment 3

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Attachment: Error Page_1031.pdf

Apply the same style as other in-content pages, such as crash reporting.

Will ping Michael about visual details early next week.

Comment 4

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: inContent_template.zip

The following attachment contains the following:

• InContent error page

• InContent design template for future use

• Specs for margins, button margins, button css and type css

• Iconography assets

Comment 5

[Marco Mucci [:MarcoM]]

Implementation to be tracked via Bug 957806.

Comment 6

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: inContent_template.zip

Updated spec.

Comment 7

[Matt Brubeck (:mbrubeck)]

Marking as fixed for Fx28 too to get this off our uplift radar (since there's no code to uplift in this design-only bug).

Comment 8

[Marco Mucci [:MarcoM]]

Hey Matt, based on your update in Comment 7, can I mark the Bug 957806 (the implementation of these assets) as invalid?

Comment 9

[Matt Brubeck (:mbrubeck)]

(In reply to Marco Mucci [:MarcoM] from comment #8)
> Hey Matt, based on your update in Comment 7, can I mark the Bug 957806 (the
> implementation of these assets) as invalid?

No, that bug is still valid (and unlike this one, it *will* contain the actual code changes and will need uplift to Aurora).

Comment 10

[Matt Brubeck (:mbrubeck)]

(In reply to mmaslaney from comment #4)
> • Specs for margins, button margins, button css and type css

The button styles here are slightly different from the button styles we are currently using in the browser chrome (added in bug 838211).  Is this intentional, or should we choose one style for both chrome and in-content UI?  It's fine if they're meant to differ; I just wanted to double check...

Comment 11

[Michael Maslaney [:mmaslaney] ([e-mail])]

My initial intent was to have them look consistent with the platform, but after some thought, I believe we should keep them consistent across the board (within Firefox) as to promote a stable experience.

Let's keep the proposed margins/size and utilize the existing button styling.

Comment 12

[u279076]

Kamil, please verify this is fixed in the latest Firefox Nightly and Aurora builds.

Comment 13

[Sam Foster [:sfoster] (he/him)]

The implementation of these designs is in 957806 which has not yet landed, there's nothing to QA on this bug.