905640 - [MP] Defect - Circular progress remains filled forever after a download

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Downloads, defect, P2)

Description

[Jim Mathies [:jimm]]

STR: 

- download something
- note the circular progress fills up

from this point on, the downloads button will always display the blue ring. Clicking on the download button does nothing, which might be a separate bug.

Comment 1

[Marina Samuel [:emtwo]]

Attachment: v1: Clear download ring on dl-done instead of on button click

Let's clear the download ring when the downloads are done instead of when a user clicks a button on the download-complete infobar.

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 792248 [details] [diff] [review]
v1: Clear download ring on dl-done instead of on button click

do we need to worry about clearing this in the dl-failed handler?

Comment 3

[Marina Samuel [:emtwo]]

(In reply to Jim Mathies [:jimm] from comment #2)
> Comment on attachment 792248 [details] [diff] [review]
> v1: Clear download ring on dl-done instead of on button click
> 
> do we need to worry about clearing this in the dl-failed handler?

Yes, thank you. We would need to clear on fail as well.

https://hg.mozilla.org/integration/fx-team/rev/c1fb5aec3201

Comment 4

[Marina Samuel [:emtwo]]

p=1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c1fb5aec3201

Comment 7

[Manuela Muntean [Away]]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130827030201

While testing this using the latest Nightly for iteration #13, I can still see the circular progress of the ring while the file is downloaded, but afterwards the blue ring disappears completely.

Is this the expected behavior?

Comment 8

[Marina Samuel [:emtwo]]

(In reply to Manuela Muntean [:Manuela] [QA] from comment #7)
> Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
> Build ID: 20130827030201
> 
> While testing this using the latest Nightly for iteration #13, I can still
> see the circular progress of the ring while the file is downloaded, but
> afterwards the blue ring disappears completely.
> 
> Is this the expected behavior?

Yes this is the intended behaviour. We have a download complete infobar to indicate to the user that their download is complete and thus the progress circle does not need to remain visible except throughout the download progress.

Though I think this works from a UX perspective, another option is to keep the blue circle visible until the infobar for a download complete is closed. Yuan what do you think?

Comment 9

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

I think keeping the blue circle visible until the user interacts with the info bar makes sense.

Comment 10

[Manuela Muntean [Away]]

Marking this VERIFIED FIXED, based on comment 7, comment 8 and comment 9. Thanks!

Comment 11

[Manuela Muntean [Away]]

I was able to reproduce this issue, while testing for iteration #14, with the latest Nightly (build ID: 20130915030208).

Comment 12

[Manuela Muntean [Away]]

Attachment: screenshot.png

The blue ring only disappears after a second download. Please see the attached screenshot for details. (the blue ring becomes gray again after a second download)

Comment 13

[Manuela Muntean [Away]]

Another relevant thing worth mentioning is that the behavior in comment 11 and comment 12 only appears if I download .pdf files. If I download a build from http://nightly.mozilla.org/ for example, everything works as expected.