905701 - Support application preferences for cameras and mics in getUserMedia() prompts (B2G)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

+++ This bug was initially created as a clone of Bug #905699 +++

+++ This bug was initially created as a clone of Bug #905696 +++

When implementing constraints for bug 882145, we'll need the UI to support being told that a specific device should be the default one shown to the user.  No string or other changes should occur; it's solely changing the default from the first device to a specified one. API TBD in bug 882145.

This bug is for B2G; it's especially useful on mobile devices for an app to specify 'front' or 'back' cameras as the default depending on the app in question.

Comment 1

[u459114]

Hi SC, can you handle this one? We need to pass the chosen camera(in media constrain) as default selected one in permission dialog

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Bug 898949 is already filed for displaying available cameras in prompt UI. I suppose this bug should either modify this sequence of the available cameras or carry a default index for UI. I'll take this bug.

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: media-constraint-for-b2g.patch

1. Mapping front/back camera to user/environment facing mode.
2. Invoke GetUserMediaDevices() with MediaStreamConstraints.

Comment 4

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Test page, "Video" for no constraints and "Front" for facingMode='user'
http://people.mozilla.org/~schien/gum-test.html

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 802961 [details] [diff] [review]
media-constraint-for-b2g.patch

Review of attachment 802961 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/MediaPermissionGonk.cpp
@@ +443,5 @@
> +  JS::Rooted<JS::Value> temp(cx);
> +  rawConstraints.ToObject(cx, JS::NullPtr(), &temp);
> +
> +  dom::RootedDictionary<dom::MediaStreamConstraintsInternal> constraints(cx);
> +  NS_ENSURE_TRUE(constraints.Init(cx, temp), NS_ERROR_FAILURE);

GetConstraints() actually expects MediaStreamConstraintsInternal, not raw MediaStreamConstraints, so you should be able to pass in |constraints| here directly to GetConstraints() without going through rawConstraints or temp.

The rest looks good, with the caveat that I still need bz to approve all this. :-)

Comment 6

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: mapping-facing-mode-for-b2g.patch

Add the mapping of facing mode for Firefox OS.

NOTE: bug 915705 already contains the modification for MediaStreamConstraints on Firefox OS.

Comment 7

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

https://tbpl.mozilla.org/?tree=Try&rev=7a5ea6ae213d

Comment 8

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Ready to land this code.

https://tbpl.mozilla.org/?tree=Try&rev=87f65c82b47f

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/bb0967aed171

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bb0967aed171