906012 - [SeaMonkey] TEST-UNEXPECTED-FAIL | test_contextmenu.html | checking item #2 (*chubbiness) name - got context-undo, expected *chubbiness

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Frank Wein [:mcsmurf]]

Currently this test fails (on beta at least, no test results for other trees):
 168909 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | checking item #2 (*chubbiness) name - got context-undo, expected *chubbiness:
168871 INFO TEST-PASS | /tests/suite/browser/test/test_contextmenu.html | Starting test #18
[...]

168906 INFO TEST-PASS | /tests/suite/browser/test/test_contextmenu.html | checking item #0 (popupwindow-reject) name
168907 INFO TEST-PASS | /tests/suite/browser/test/test_contextmenu.html | checking item #0 (popupwindow-reject) enabled state
168908 INFO TEST-PASS | /tests/suite/browser/test/test_contextmenu.html | checking item #1 (---) name
168909 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | checking item #2 (*chubbiness) name - got context-undo, expected *chubbiness
168910 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | checking item #2 (*chubbiness) enabled state - got false, expected true
168911 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | checking item #3 (---) name - got context-redo, expected ---
168912 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | checking item #4 (spell-add-to-dictionary) name - got ---, expected spell-add-to-dictionary
168913 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | checking item #4 (spell-add-to-dictionary) enabled state - got null, expected true
[...]

I think http://hg.mozilla.org/mozilla-central/rev/6b29a5c94955 (Bug 856270) might be related here.

Comment 1

[Philip Chee]

Also see:

Bug 905176 - Don't show the Check Spelling menu item for spellcheck=false contenteditable elements

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Test fix

Straight-forward port of http://hg.mozilla.org/mozilla-central/rev/6b29a5c94955 to SeaMonkey, trivial test fix, no review needed.

Comment 3

[Frank Wein [:mcsmurf]]

Attachment: Test fix

Comment 4

[Frank Wein [:mcsmurf]]

Comment on attachment 793712 [details] [diff] [review]
Test fix

[Approval Request Comment]
Regression caused by (bug #): Bug 856270
User impact if declined: -
Testing completed (on m-c, etc.): Works fine locally, test fix only
Risk to taking this patch (and alternatives if risky): Test fix only
String changes made by this patch: -

Comment 5

[Ian Neal]

Comment on attachment 793712 [details] [diff] [review]
Test fix

As these are just test fixes, they probably could have just landed with a suitable a=

Comment 6

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/comm-central/rev/480f28c2f35f

Comment 7

[Frank Wein [:mcsmurf]]

Pushed to aurora: https://hg.mozilla.org/releases/comm-aurora/rev/ff56a3c685ee

Comment 8

[Frank Wein [:mcsmurf]]

Pushed to beta: https://hg.mozilla.org/releases/comm-beta/rev/9a18d0a991cc

Will file a new bug for the issue in Comment 1