Closed Bug 916865 Opened 6 years ago Closed 5 years ago

Revert the part of Bug 906083 which changed the spellchecker.dictionaries.download.url

Categories

(SeaMonkey :: Preferences, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.29

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file)

From Bug 906083 Comment 5:
>>-spellchecker.dictionaries.download.url=https://addons.mozilla.org/%LOCALE%/%APP%/dictionaries
>>+spellchecker.dictionaries.download.url=https://addons.mozilla.org/%LOCALE%/%APP%/language-tools/
> 
> The dictionaries URL should not be changed, what you're doing there is
> wrong. The /dictionaries URL is a generic redirect to wherever we actually
> host them, which might change. Even Firefox uses this, see
> http://mxr.mozilla.org/comm-central/source/mozilla/browser/app/profile/
> firefox.js#68 - so we should keep using the /dictionaries alias here.

> Also, I wonder why the /themes link has a forced sort order applied.
As far as I can tell, adding a query string is the only way to get a list of background themes without pollution from complete themes.
(In reply to Philip Chee from comment #0)
> > Also, I wonder why the /themes link has a forced sort order applied.
> As far as I can tell, adding a query string is the only way to get a list of
> background themes without pollution from complete themes.

I probably would have gone and folded the two links/items for full and lightweight themes into a single one for themes and used the /themes link for that, given that both variants are now hosted at the same site.
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #812035 - Flags: review?(iann_bugzilla)
Attachment #812035 - Flags: review?(iann_bugzilla) → review+
I seem to have forgotten this one.
Pushed to comm-central
https://hg.mozilla.org/comm-central/rev/7f20f6b479da
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.29
You need to log in before you can comment on or make changes to this bug.