906199 - overflow:hidden only hides immediate children if 3d style applied.

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[ninjaqe]

Attachment: FF_Overflow3dBug.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.95 Safari/537.36

Steps to reproduce:

Using overflow:hidden to a tag with 3d style that have a nested tag (grand child) also with 3d style.


Actual results:

Only the child level tag is cropped by the overflow:hidden but the grand child tag is not cropped. This happens in Firefox 23 (and 24 nightly build) but unable to reproduce with FF 22 and webkit browsers.


Expected results:

overflow:hidden crops grand child level element with 3d.

Comment 1

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/f4f549a04ee8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130405 Firefox/23.0 ID:20130405125522
Bad:
http://hg.mozilla.org/mozilla-central/rev/139b6ba547fa
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130405 Firefox/23.0 ID:20130405131405
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f4f549a04ee8&tochange=139b6ba547fa

Regressed by:Bug 841192

Comment 2

[bhavana bajaj [:bajaj]]

Roc, can you please help with this, may be a fallout form 841192 ?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This fixes 907078, 903587, and 902546 as well.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4dd5fb21e599

Comment 6

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/106efdd9b266 for Android's https://tbpl.mozilla.org/php/getParsedLog.php?id=26803688&tree=Mozilla-Inbound

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/954a7a7a5051 with some fuzz.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/954a7a7a5051

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 792763 [details] [diff] [review]
fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 841192
User impact if declined: broken rendering on some sites using 3D transforms
Testing completed (on m-c, etc.): just landed
Risk to taking this patch (and alternatives if risky): pretty low-risk patch. At least, it's unlikely to make things any worse since it only affects preserve-3d with clipping that's currently broken.
String or IDL/UUID changes made by this patch: none

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3667169831cb
https://hg.mozilla.org/releases/mozilla-beta/rev/b85f944181d8

Comment 11

[Ioana (away)]

Verified as fixed on Firefox 24 beta 6 (20130826142034) - Windows 7 64bit, Ubuntu 13.04 32bit and Mac OSX 10.7.5.

Comment 13

[Tiziana Sellitto [:tiziana]]

Verified as fixed on
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130830030205 
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0) Gecko/20100101 Firefox/25.0 ID:20130830004004

Comment 14

[Ioana (away)]

Also verified on Firefox 25:
Mac OS X 10.8.4 - 20130912004004
Ubuntu 13.04 - 20130911004006
Windows 7 - 20130912004004

Comment 15

[Ioana (away)]

Updating flags per comment 13.