Closed
Bug 906199
Opened 11 years ago
Closed 11 years ago
overflow:hidden only hides immediate children if 3d style applied.
Categories
(Core :: Layout, defect)
Tracking
()
VERIFIED
FIXED
mozilla26
People
(Reporter: ninjaqe, Assigned: roc)
References
(Depends on 1 open bug)
Details
(Keywords: regression, testcase)
Attachments
(2 files)
1.62 KB,
text/html
|
Details | |
3.33 KB,
patch
|
mattwoodrow
:
review+
bajaj
:
approval-mozilla-aurora+
bajaj
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.95 Safari/537.36 Steps to reproduce: Using overflow:hidden to a tag with 3d style that have a nested tag (grand child) also with 3d style. Actual results: Only the child level tag is cropped by the overflow:hidden but the grand child tag is not cropped. This happens in Firefox 23 (and 24 nightly build) but unable to reproduce with FF 22 and webkit browsers. Expected results: overflow:hidden crops grand child level element with 3d.
![]() |
||
Updated•11 years ago
|
Attachment #791481 -
Attachment mime type: text/plain → text/html
![]() |
||
Comment 1•11 years ago
|
||
Regression window(m-c) Good: http://hg.mozilla.org/mozilla-central/rev/f4f549a04ee8 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130405 Firefox/23.0 ID:20130405125522 Bad: http://hg.mozilla.org/mozilla-central/rev/139b6ba547fa Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130405 Firefox/23.0 ID:20130405131405 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f4f549a04ee8&tochange=139b6ba547fa Regressed by:Bug 841192
Blocks: 841192
Status: UNCONFIRMED → NEW
status-firefox23:
--- → affected
tracking-firefox24:
--- → ?
tracking-firefox25:
--- → ?
tracking-firefox26:
--- → ?
Component: Untriaged → Layout
Ever confirmed: true
Keywords: regression
OS: Mac OS X → All
Product: Firefox → Core
Comment 2•11 years ago
|
||
Roc, can you please help with this, may be a fallout form 841192 ?
Flags: needinfo?(roc)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → roc
Flags: needinfo?(roc)
Updated•11 years ago
|
Attachment #792763 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4dd5fb21e599
Updated•11 years ago
|
status-firefox24:
--- → affected
status-firefox25:
--- → affected
Comment 6•11 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/106efdd9b266 for Android's https://tbpl.mozilla.org/php/getParsedLog.php?id=26803688&tree=Mozilla-Inbound
Assignee | ||
Comment 7•11 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/954a7a7a5051 with some fuzz.
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/954a7a7a5051
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox26:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Assignee | ||
Comment 9•11 years ago
|
||
Comment on attachment 792763 [details] [diff] [review] fix [Approval Request Comment] Bug caused by (feature/regressing bug #): 841192 User impact if declined: broken rendering on some sites using 3D transforms Testing completed (on m-c, etc.): just landed Risk to taking this patch (and alternatives if risky): pretty low-risk patch. At least, it's unlikely to make things any worse since it only affects preserve-3d with clipping that's currently broken. String or IDL/UUID changes made by this patch: none
Attachment #792763 -
Flags: approval-mozilla-beta?
Attachment #792763 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #792763 -
Flags: approval-mozilla-beta?
Attachment #792763 -
Flags: approval-mozilla-beta+
Attachment #792763 -
Flags: approval-mozilla-aurora?
Attachment #792763 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/3667169831cb https://hg.mozilla.org/releases/mozilla-beta/rev/b85f944181d8
Assignee | ||
Updated•11 years ago
|
Comment 11•11 years ago
|
||
Verified as fixed on Firefox 24 beta 6 (20130826142034) - Windows 7 64bit, Ubuntu 13.04 32bit and Mac OSX 10.7.5.
QA Contact: ioana.budnar
Comment 13•11 years ago
|
||
Verified as fixed on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130830030205 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0) Gecko/20100101 Firefox/25.0 ID:20130830004004
Comment 14•11 years ago
|
||
Also verified on Firefox 25: Mac OS X 10.8.4 - 20130912004004 Ubuntu 13.04 - 20130911004006 Windows 7 - 20130912004004
You need to log in
before you can comment on or make changes to this bug.
Description
•