906520 - Add promptUsernameAndPassword capabilities to test-prompt-helpers.js

Status: NEW

(Thunderbird :: Testing Infrastructure, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Jon Demelo, my GSoC student this summer, needs this capability to test the authentication portion of his CardDAV connector for Ensemble.

Comment 1

[Jonathan Demelo]

Attachment: promptUsernameAndPassword.patch

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 798367 [details] [diff] [review]
promptUsernameAndPassword.patch

Review of attachment 798367 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Just fix that whitespace nit, and I'll land this for you.

::: mail/test/mozmill/shared-modules/test-prompt-helpers.js
@@ +133,5 @@
>      return this._will_return;
>    },
>  
> +  promptUsernameAndPassword: function(aParent, aDialogTitle, aText,
> +                                      aUsername, aPassword, aCheckMsg, 

Nit - trailing whitespace.

Comment 3

[Jonathan Demelo]

Attachment: promptUsernameAndPassword_V2.patch